Add sufficient information in matter idl to reconstruct acronym/non-acronym logic on constant names #38888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38888: Size comparison from b16122c to de5bdd6 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38888 +/- ##
===========================================
+ Coverage 57.26% 72.64% +15.37%
===========================================
Files 130 729 +599
Lines 12654 52063 +39409
===========================================
+ Hits 7246 37819 +30573
- Misses 5408 14244 +8836 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bzbarsky-apple
approved these changes
May 12, 2025
2 tasks
tcarmelveilleux
approved these changes
May 12, 2025
|
PR #38888: Size comparison from b16122c to 6426efb Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
…cronym logic on constant names (project-chip#38888) * Add the ability to generate specification name from matter idl * Support parsing of specification names * Updated example a bit * zap regen * Update with real world examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is as a sideffect from #38843 (comment)
We would rather have sufficient information to fully reconstruct names for things instead of heuristics. This adds names in the case where with/without acronym logic results differ (so that we reduce redundancy/noise).
Testing
Unit tests updated/added.