[Closure] Closure Dimension command implementations for Closure Linux app #39785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request implements the set-target and step commands for the closure dimension cluster. The changes look promising, but I've found several critical issues related to potential crashes from unsafe memory access and incorrect asynchronous logic. I've also noted some areas for improvement regarding code duplication and maintainability.
|
PR #39785: Size comparison from 9100f28 to bd76b64 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39785: Size comparison from 9100f28 to 8be3489 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39785: Size comparison from 9151e79 to ace005a Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
AliTalebVelux
approved these changes
Jul 3, 2025
jepenven-silabs
approved these changes
Jul 4, 2025
|
PR #39785: Size comparison from 860799f to 2d36470 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39785: Size comparison from 4944739 to d189f95 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 7, 2025
… app (project-chip#39785) * Restyled by whitespace * Addressign PR comments * Addressing PR comments * Addressing PR comments * set-target initial implementation for linux app * Set-target and step command code as per latest spec changes * Revert common changes * Restyled by whitespace * Restyled by clang-format * Code cleanup * Restyled by clang-format * Separate timers for all the endpoints * Restyled by clang-format * Fix issues after rebase * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Satya Naag Bollimpalli <sabollim@silabs.com> Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the closure dimension cluster commands (set-target and step) implementation for closure linux app.
Set-target command is an asynchronous command which moves the position of the panel to the target position at a rate of 1000 units per second.
Step command is an asynchronous command which increases or decreases the position of the panel by the given number of steps. In each step, the position of panel is changed at the rate of 'stepValue', which is configured in the cluster.
Dependencies :
The GetPanelNextPosition() API is being added in this PR : #39728
The OnActionComplete APIs in Closure dimension and Closure Control are being added in this PRs : #39726 , #39718
Related issues
N/A
Testing
Build clousre sample app, commsission using chip tool and
./chip-tool closuredimension step 1 10 1 2 --Speed 2 -> SUCCESS (increases the position by 10 steps for panel2)
./chiptool closuredimention set-target 1 --Position 5000 --Latch false --Speed 2 -> SUCCESS (moves position to 5000 for panel2)
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines