[Closure] Closure control command implementations in linux app #39728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/closure-app/closure-common/src/ClosureDimensionEndpoint.cpp
Outdated
Show resolved
Hide resolved
|
PR #39728: Size comparison from a8817cc to 7ed1b50 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jun 27, 2025
7ed1b50 to
48e4046
Compare
|
PR #39728: Size comparison from 77d91c0 to 70c8974 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
5 tasks
|
PR #39728: Size comparison from 77d91c0 to 59ca1ef Full report (3 builds for nrfconnect)
|
|
PR #39728: Size comparison from 9151e79 to 5f76692 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
AliTalebVelux
approved these changes
Jul 2, 2025
jepenven-silabs
approved these changes
Jul 3, 2025
|
PR #39728: Size comparison from 5ad1201 to b90c559 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #39728: Size comparison from 5ad1201 to efdb188 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39728: Size comparison from 1f94f79 to 1c27d82 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 7, 2025
…ct-chip#39728) * linux app common code and claibrate * Restyled by clang-format * cleaning duplicate include s * Stop command implementation for linux * Stop command code for linux app * Restyled by clang-format * Remove common code changes * Moveto command implementation * Restyled by whitespace * Restyled by clang-format * Fix variable names * Restyled by clang-format * Add separate timers for different endpoints * Restyled by whitespace * Restyled by clang-format * PR comments1' --------- Co-authored-by: Satya Naag Bollimpalli <sabollim@silabs.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: sabollim-silabs <158290810+sabollim-silabs@users.noreply.github.com> Co-authored-by: sabollim <satyanaag.bollimpalli@silabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the closure control commands (stop and move-to) implementation for closure linux app.
Stop command is synchronous command which will stop any ongoing operation and set the final state of endpoints.
Move-To command is an asynchronous command, which moves at a rate of 1000 units per second.
Related issues
N/A
Testing
Validated the linux app across TestScripts : TC_CLCTRL_2_1.py, TC_CLCTRL_4_2.py, TC_CLCTRL_4_3.py, TC_CLCTRL_4_4.py
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines