8000 Fix RETRY() error-handling by austin3dickey · Pull Request #581 · r-lib/httr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix RETRY() error-handling #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix RETRY() error-handling #581

merged 1 commit into from
Apr 1, 2019

Conversation

austin3dickey
Copy link
Contributor

This PR fixes a few issues where an unsuccessful request_perform() during a RETRY() will prematurely fatal with the following error message:

Error in UseMethod("http_error") : no applicable method for 'http_error' applied to an object of class "c('simpleError', 'error', 'condition')"

Now, RETRY() will successfully retry in those cases. This fix was @hadley 's suggestion.

Fixes #569
Fixes #574

@hadley hadley merged commit 0dc7559 into r-lib:master Apr 1, 2019
@hadley
Copy link
Member
hadley commented Apr 1, 2019

Thanks!

@jameslamb jameslamb mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RETRY errors on curl timeout RETRY error message
2 participants
@austin3dickey @hadley
0