8000 Fix flaky RETRY unit test by jameslamb · Pull Request #586 · r-lib/httr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix flaky RETRY unit test #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2019
Merged

Fix flaky RETRY unit test #586

merged 1 commit into from
Apr 28, 2019

Conversation

jameslamb
Copy link
Contributor

I noticed that recent builds of httr are failing (e.g. https://travis-ci.org/r-lib/httr/jobs/517331103) with an error like:

image

I could not reproduce this problem on my Mac tonight, which suggests to me that it has something to do with different underlying versions of either the curl R package or libcurl in the CI environment vs. my local dev environment.

In this PR, I propose making the regexp in that test less specific. I do still think it's important to have some regexp there to be sure you got the actual curl error surfaced (since that was the intent of #581).

Thanks for considering this. I think it will unblock #582 , #583 , and #585

@jameslamb
Copy link
Contributor Author

The build errors look unrelated to my changes:

image

I saw a lot of this type of error 8000 with the breaking changes in devtools 2.0.0. I don't see anything obvious in the .travis.yml...is the issue present on all language: r builds on Travis? 😬

@jameslamb
Copy link
Contributor Author

I ended up force-pushing with 0 changes to get Travis to kick off again

@jameslamb
Copy link
Contributor Author

This worked! Think whatever was going on with the build environment for R projects on Travis was resolved.

@hadley at your earliest convenience, could I get a review?

@hadley hadley merged commit b924ac3 into r-lib:master Apr 28, 2019
@hadley
Copy link
Member
hadley commented Apr 28, 2019

Thanks. But please don't continue to ping me directly, especially for something as minor as this.

@jameslamb
Copy link
Contributor Author

Sure, sorry. Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @hadley
0