FIX unknown status code (#567) #585
Conversation
R/response-status.r
Outdated
| @@ -46,11 +46,12 @@ status_code.numeric <- function(x) x | |||
| http_status <- function(x) { | |||
| status <- status_code(x) | |||
|
|
|||
| status_desc <- http_statuses[[as.character(status)]] | |||
| if (is.na(status_desc)) { | |||
| if (isFALSE(status %in% names(http_statuses))) { | |||
There was a problem hiding this comment.
isFALSE() isn't a good approach here because it's only available in recent versions of R, and it's strictness isn't needed as we know that %in% always returns a logical vector with the same length as the LHS.
There was a problem hiding this comment.
isFALSE was here mostly to handle cases if status is NA for some reason. But apparently, %in% already handles it as well. Force changed the code.
1c9aa6e to
9af70f8
Compare
There was a problem hiding this comment.
Can you please add a bullet to NEWS? It should briefly describe the change and end with (@yourname, #issuenumber).
9af70f8 to
422b024
Compare
|
Updated. |
|
For future reference, if you include |
Fixes issue (#567) with unknown status code. Slightly modified solution from original offered by @hadley.