8000 Uppercase methods by patr1ckm · Pull Request #583 · r-lib/httr · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Uppercase methods #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2020
Merged

Uppercase methods #583

merged 3 commits into from
Apr 3, 2020

Conversation

patr1ckm
Copy link
Contributor
@patr1ckm patr1ckm commented Apr 1, 2019 •
edited
Loading

This uses uppercase methods everywhere by default, for use primarily in VERB and RETRY.

This approach does a bit of extra work but was easier to test. An alternative is to implement the change only for VERB and RETRY, which I can do if you prefer.

Note that the curl options in request_prepare will now be set for formerly lowercase get and post calls, which were handled as custom calls previously.

    GET = req$options$httpget <- TRUE,
    POST = req$options$post <- TRUE,

The result is that

httr::VERB('get', 'google.com')

Now returns a 200.

Fixes #571 .

@jameslamb jameslamb mentioned this pull request Apr 9, 2019
Merged
@hadley hadley merged commit 42efb48 into r-lib:master Apr 3, 2020
@hadley
Copy link
Member
hadley commented Apr 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically uppercase methods
2 participants
@patr1ckm @hadley
0