8000 Add an example for bip32 key derivation by rikitau · Pull Request #502 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add an example for bip32 key derivation #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2020
Merged

Add an example for bip32 key derivation #502

merged 1 commit into from
Oct 25, 2020

Conversation

rikitau
Copy link
Contributor
@rikitau rikitau commented Oct 16, 2020

Dear 🦀-bitcoin people, I started using rust-bitcoin crate for my thesis and it is wonderful! Thank you for your amazing work!

For some people like myself it might be difficult to start using the crate without hello-world examples.
So I got up the courage to offer an example on the bip32 functionality.

Excuse me if the quality of my code does not meet the standards. I will be happy to improve it if you give me a code review.

@apoelstra
Copy link
Member

This looks great!

I'm a little surprised that you had to do so much parsing of the seed -- it looks like this is a standard WIF-encoded privkey? Could you have used bitcoin::PrivateKey::from_str to do the parsing?

@rikitau
Copy link
Contributor Author
rikitau commented Oct 17, 2020

Thank you! I updated the example using ::from_wif for parsing.

@rikitau
Copy link
Contributor Author
rikitau commented Oct 17, 2020

Continuous integration fails, last time it was ok...
CI details say it's because of bitcoin_hashes and serde_macros.
I assume it's not my fault because I didn't touch anything except my example...
What should I do now?

@apoelstra
Copy link
Member

I'm sorry, it's my fault -- I broke the build in the last update of bitcoin_hashes. I'll try to have a fix published this weekend then I'll restart the CI here. Nothing you need to do.

@jrawsthorne jrawsthorne mentioned this pull request Oct 18, 2020
Closed
apoelstra
apoelstra approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

stevenroose
stevenroose approved these changes Oct 25, 2020
View reviewed changes
Copy link
Collaborator
@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@stevenroose stevenroose merged commit 76a1a32 into rust-bitcoin:master Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenroose stevenroose stevenroose approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikitau @apoelstra @stevenroose
0