Trivial dependency cleanup #1563
Conversation
|
I vote that we merge PRs even if ASAN fix shows a big red |
ASAN is fixed now :) see #1566 |
bitcoin/Cargo.toml
Outdated
|
|
||
| base64 = { version = "0.13.0", optional = true } | ||
| bitcoinconsensus = { version = "0.20.2-0.5.0", optional = true, default-features = false } | ||
| # You probably want to use "no-std" instead of using these two features directly. |
There was a problem hiding this comment.
I'd actually love to split these and remove no-std :P
There was a problem hiding this comment.
hmmm, I'll keep that in mind. I don't like how we have different crates using std/alloc differently, its a pain to remember (reffering to the fact that sometimes "std" enables "alloc" and sometimes not).
There was a problem hiding this comment.
I think I already said std should always enable alloc. core2 should be orthogonal. Although we need core2 because of IO traits being everywhere for now.
There was a problem hiding this comment.
Yeah, I finally worked this out. I was getting confused by the HexWriter that uses core2 and alloc - now its removed and I've started to separate "alloc" from "core2" (both in mind and in PRs).
bded792 to
62d3973
Compare
|
I think we should get #1576 in first. |
|
Should be rebased (and the resulting Cargo.toml manually checked, because git and github don't see conflicts even though there clearly is one) since #1576 was merged. |
62d3973 to
46d6e57
Compare
|
Rebased and checked the diff and toml files. "What Tobin, you don't always check your diffs after rebasing and before pushing?" - "sure I do, what sort of noob dev do you take me for" (averts eyes sheepishly). |
|
This PR now introduces a |
Put the `core2` optional dependency down with the other optional dependencies. While we are at it put the `core2` and `hashbrown` dependencies together under a comment directing users towards the "no-std" feature which enables them.
Put the `optional = true` dependency config at the end of the line like it is for all the other optional dependencies.
46d6e57 to
8ca4cf5
Compare
|
Guess my joke got lost in translation :) |
|
Superseded by #1612 |
Do two trivia cleanups to the bitcoin manifest.
Refactor only, no logic changes.