bip158: Replace usage of HashSet with BTreeSet #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
requested changes
Jan 22, 2023
|
And yes, I like removing it without claiming anything about perf and re-adding if perf is affected and we can't resolve it without adding the dep. |
The `bip158` module uses a `HashSet` and in order to do so requires the `hashbrown` dependency for "no-std" builds. We can replace the usage of `HashSet` with a `BTreeSet` in `bip158` and remove the `hashbrown` dependency entirely. This patch makes no claims about performance cost or benefit of this change. The patch also makes no claims about the validity of the current `HashSet` usage. The `hashbrown` dependency and `HashSet` usage can be trivially added back in if someone comes up with perf data to back it up.
960e0ef to
6e56fee
Compare
Face palm, done. |
Kixunil
approved these changes
Jan 23, 2023
apoelstra
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bip158module uses aHashSetand in order to do so requires thehashbrowndependency for "no-std" builds.We can replace the usage of
HashSetwith aBTreeSetinbip158and remove thehashbrowndependency entirely.This patch makes no claims about performance cost or benefit of this change. The patch also makes no claims about the validity of the current
HashSetusage.The
hashbrowndependency andHashSetusage can be trivially added back in if someone comes up with perf data to back it up.