Bump rust-version to 1.73.0 #193
Conversation
|
Btw I'll probably merge eagerly, this without blocking on review, considering that this seems pretty uncontroversial and it should be fine to follow up with any issue if necessary in another PR (and I want to stack other changes / PRs on this). |
5775f17 to
825afb5
Compare
I don't think we really need to "track" two versions; our developer-only build tools can just use whatever is the latest |
android-activity/Cargo.toml
Outdated
| # We need a version > 1.70 for running bindgen-cli, and 1.73 also happens to | ||
| # have a fix for the definition of the `stat` struct on Android. | ||
| rust-version = "1.73.0" |
There was a problem hiding this comment.
I don't think mentioning bindgen-cli is very relevant here (and I'd be more than happy to keep them separate). Having it in the PR description is more than enough.
I guess rust-bindgen could change it's output for any major version, regardless of the I guess it's also valid to pass a I think it's OK to leave it to the PR that's updating to GameActivity 4.0.0 for re-generating new bindings. The bindings themeselves are private, so it's up to us to choose to re-generate if we want to take advantage of new bindgen features or when changing the native |
yeah, fair enough - this version bump is technically not really needed. any particular objection to me updating the rust-version to 1.73 anyway? there is the |
|
No objections as long as it's not specifically on the merit of our developer tools/experience 👍 |
I'll update the commit message / comments etc to only refer to the I'll keep the |
|
Yeah, love to see the |
825afb5 to
4b11d64
Compare
There was a fix for the definition of the `stat` struct on Android in 1.73, and even though it's unlikely to affect many applications it still seems worthwhile to draw a line under this and ensure that all android-activity based applications will have that fix. Rust 1.73 was released October 2023, which is still well over a year old and very conservative. This updates `generate-bindings.sh` to pass `--rust-target 1.73.0` so we avoid generating bindings that require a more recent compiler. (This doesn't actually regenerate the bindings but does ensure that future updates will be constrained to generate code that is backwards compatible with 1.73.)
4b11d64 to
b570174
Compare
bindgen-cli 0.71 (which we want to use) requires rustc >= 1.70
If we're bumping the rust version anyway it looks like it makes sense to at least bump to 1.73 which happens to fix the
statstruct definition for Android.Technically since we run bindgen-cli offline, their minimum version doesn't need to affect us but I'd rather just sync and not track multiple "minimum" versions for this crate.
Rust 1.73 was released October 2023, which is still well over a year old and very conservative.
This updates
generate-bindings.shto pass--rust-target 1.73.0so we avoid generating bindings that require a more recent compiler.