8000 bench: match default BoringSSL/OpenSSL ticket count by ctz · Pull Request #2167 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

bench: match default BoringSSL/OpenSSL ticket count #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Oct 17, 2024

We send four tickets by default, which shows up in benchmarking of server-side resumption cost versus BoringSSL/OpenSSL (which default to two).

Copy link
rustls-benchmarking bot commented Oct 17, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10494180 10445537 -48643 (-0.46%) 1.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10862521 10813504 -49017 (-0.45%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8582948 8562711 -20237 (-0.24%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10832938 10814551 -18387 (-0.17%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8605060 8598211 -6849 (-0.08%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087154 3085205 -1949 (-0.06%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624819 3625123 304 (0.01%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1278668 1278751 83 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1280937 1280856 -81 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623517 3623707 190 (0.01%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178866 2178777 -89 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925964 1925986 22 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30327177 30327485 308 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34159568 34159836 268 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30312703 30312853 150 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3082921 3082936 15 (0.00%) 0.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30726502 30726354 -148 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717449 1717456 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34153576 34153444 -132 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30349340 30349236 -104 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30760640 30760544 -96 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34153837 34153752 -85 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32146027 32146099 72 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34159601 34159525 -76 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30783119 30783183 64 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30760736 30760795 59 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32142987 32143045 58 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30363273 30363317 44 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34156256 34156211 -45 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619693 7619703 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748951 30748918 -33 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30348701 30348732 31 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30313428 30313400 -28 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32146111 32146083 -28 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32089952 32089927 -25 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185103 35185128 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32093087 32093109 22 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30726643 30726662 19 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34150207 34150191 -16 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389588 46389597 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460143 46460134 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348117 58348106 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480088 46480096 8 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32093091 32093096 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58351862 58351871 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718219 92718209 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434715 46434720 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648876 80648884 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661846 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683805 68683800 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58236453 58236449 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641261 80641256 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92711977 92711982 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251178 58251175 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253411 58253414 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255489 58255492 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714219 92714215 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487100 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535646 80535649 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540446 80540449 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673125 92673128 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467126 46467127 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467812 46467813 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682196 92682195 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481800 11481800 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43976204 43976204 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42259298 42259298 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43979319 43979319 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43979279 43979279 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58340960 58340960 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4693603 4693603 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41812362 41812362 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292292 11292292 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662156 2662156 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43888719 43888719 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554935 80554935 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497513 4497513 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798626 41798626 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42186068 42186068 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475844 11475844 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656291 2656291 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42245425 42245425 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43320289 43320289 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1664483 1664483 0 (0.00%) 1.05%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012105 5012105 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43215287 43215287 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932707 1932707 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43885604 43885604 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183198 35183198 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42172123 42172123 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41710146 41710146 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41724372 41724372 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43322927 43322927 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873385 3873385 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3890031 3890031 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43322946 43322946 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617549 7617549 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470692 46470692 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41798136 41798136 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42171601 42171601 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215739 4215739 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175749 2175749 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684031 92684031 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236729 4236729 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563535 2563535 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4250539 4250539 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244831 42244831 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1663114 1663114 0 (0.00%) 1.04%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43215306 43215306 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43888679 43888679 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41710636 41710636 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43212649 43212649 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.23 ms -0.07 ms (-1.40%) 4.26%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.50 ms -0.06 ms (-1.38%) 5.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.22 ms 5.15 ms -0.07 ms (-1.32%) 3.82%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.13 ms -0.06 ms (-1.21%) 4.29%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.47 ms 6.40 ms -0.08 ms (-1.17%) 3.46%
transfer_no_resume_ring_1.3_rsa_aes 6.96 ms 6.89 ms -0.07 ms (-1.06%) 3.47%
transfer_no_resume_ring_1.2_rsa_aes 6.87 ms 6.80 ms -0.07 ms (-1.03%) 3.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 470.52 µs 466.09 µs -4.43 µs (-0.94%) 4.32%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.57 ms 9.50 ms -0.08 ms (-0.80%) 2.09%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.10 ms -0.01 ms (-0.80%) 9.17%
handshake_no_resume_ring_1.3_ecdsap256_chacha 508.18 µs 504.23 µs -3.95 µs (-0.78%) 2.59%
handshake_no_resume_ring_1.3_ecdsap256_aes 513.41 µs 509.78 µs -3.63 µs (-0.71%) 3.15%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.07 ms 13.00 ms -0.08 ms (-0.59%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.04 ms 12.97 ms -0.08 ms (-0.58%) 1.73%
transfer_no_resume_ring_1.3_rsa_chacha 13.56 ms 13.49 ms -0.07 ms (-0.55%) 1.63%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.77 ms 13.70 ms -0.07 ms (-0.52%) 1.53%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.17 ms 16.09 ms -0.08 ms (-0.51%) 1.22%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.47%) 2.14%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.06 ms -0.01 ms (-0.47%) 3.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 465.60 µs 463.56 µs -2.04 µs (-0.44%) 4.06%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.68 ms 13.62 ms -0.06 ms (-0.42%) 1.61%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.61 ms 4.59 ms -0.02 ms (-0.41%) 1.96%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.00 ms -0.00 ms (-0.40%) 1.08%
handshake_no_resume_ring_1.3_rsa_chacha 1.00 ms 1.00 ms -0.00 ms (-0.40%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.93 ms 4.91 ms -0.02 ms (-0.39%) 2.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.33 ms 5.31 ms -0.02 ms (-0.39%) 1.97%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.60 ms -0.01 ms (-0.39%) 5.28%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.25 ms 5.23 ms -0.02 ms (-0.38%) 2.07%
handshake_no_resume_ring_1.2_rsa_aes 997.83 µs 994.11 µs -3.72 µs (-0.37%) 1.16%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.93 ms 4.91 ms -0.02 ms (-0.37%) 1.80%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.01 ms (-0.35%) 2.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.59 ms 4.57 ms -0.02 ms (-0.35%) 1.59%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.77 ms -0.01 ms (-0.33%) 5.40%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.57 ms 5.56 ms -0.02 ms (-0.30%) 2.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.30 ms 5.29 ms -0.02 ms (-0.28%) 1.57%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.24 ms 5.22 ms -0.01 ms (-0.28%) 2.54%
handshake_tickets_ring_1.3_ecdsap256_aes 6.72 ms 6.70 ms -0.02 ms (-0.28%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.64 ms 5.63 ms -0.02 ms (-0.27%) 1.82%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.67 ms 6.65 ms -0.02 ms (-0.26%) 1.13%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.65 ms 5.64 ms -0.01 ms (-0.25%) 1.83%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.25%) 1.40%
handshake_session_id_ring_1.3_ecdsap256_aes 6.59 ms 6.57 ms -0.02 ms (-0.25%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.10 ms 1.09 ms -0.00 ms (-0.23%) 8.86%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.54 ms 6.53 ms -0.01 ms (-0.20%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.19 ms 1.18 ms -0.00 ms (-0.20%) 1.71%
handshake_tickets_ring_1.3_rsa_aes 7.21 ms 7.19 ms -0.01 ms (-0.20%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.58 ms 5.57 ms -0.01 ms (-0.15%) 2.65%
handshake_session_id_ring_1.3_rsa_chacha 7.03 ms 7.02 ms -0.01 ms (-0.12%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.15 ms 7.15 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.08 ms 7.07 ms -0.01 ms (-0.10%) 1.01%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.80 ms 9.79 ms -0.01 ms (-0.08%) 1.00%
handshake_sess 8000 ion_id_ring_1.3_ecdsap384_aes 9.66 ms 9.65 ms -0.01 ms (-0.07%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.75 ms 9.74 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.61 ms 9.61 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz enabled auto-merge October 17, 2024 16:29
Copy link
codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (13144a0) to head (c02dffc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2167   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         102      102           
  Lines       23753    23753           
=======================================
  Hits        22499    22499           
  Misses       1254     1254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit b553880 Oct 17, 2024
60 checks passed
@ctz ctz deleted the jbp-bench-tls13-ticket-count branch October 17, 2024 17:42
@ctz ctz mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0