8000 Faster TLS1.3 server resumption by ctz · Pull Request #2168 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Faster TLS1.3 server resumption #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2024
Merged

Faster TLS1.3 server resumption #2168

merged 2 commits into from
Oct 18, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Oct 17, 2024

First commit fixes a small bit of wastefulness. Its effect is somewhat tempered by #2167 , but worth having.
Second commit expands the scope of #2120.

Indicative performance results:

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 17, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32090239 30020544 ✅ -2069695 (-6.45%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32093157 30023517 ✅ -2069640 (-6.45%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32093122 30023583 ✅ -2069539 (-6.45%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32143169 30070672 ✅ -2072497 (-6.45%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32146011 30073742 ✅ -2072269 (-6.45%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32145977 30074003 ✅ -2071974 (-6.45%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1278675 1208598 ✅ -70077 (-5.48%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1280863 1210870 ✅ -69993 (-5.46%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34156164 32423161 ✅ -1733003 (-5.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34159756 32426597 ✅ -1733159 (-5.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34159552 32426809 ✅ -1732743 (-5.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34150396 32426347 ✅ -1724049 (-5.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34153873 32429693 ✅ -1724180 (-5.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34153872 32429744 ✅ -1724128 (-5.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175849 2105665 ✅ -70184 (-3.23%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178777 2108693 ✅ -70084 (-3.22%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43322927 42647477 ✅ -675450 (-1.56%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43322946 42647511 ✅ -675435 (-1.56%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43320289 42644903 ✅ -675386 (-1.56%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43215306 42558786 ✅ -656520 (-1.52%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43212649 42556178 ✅ -656471 (-1.52%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43215287 42558797 ✅ -656490 (-1.52%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1664483 1641154 ✅ -23329 (-1.40%) 1.04%
handshake_tickets_ring_1.3_rsa_aes_server 43976204 43377336 ✅ -598868 (-1.36%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43979319 43380455 ✅ -598864 (-1.36%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43979279 43380481 ✅ -598798 (-1.36%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43885604 43317546 ✅ -568058 (-1.29%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43888719 43320665 ✅ -568054 (-1.29%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43888679 43320661 ✅ -568018 (-1.29%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1663078 1644089 ✅ -18989 (-1.14%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30760708 30598877 ✅ -161831 (-0.53%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30783181 30621396 ✅ -161785 (-0.53%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30760704 30599423 ✅ -161281 (-0.52%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30327204 30182331 ✅ -144873 (-0.48%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30313307 30168577 ✅ -144730 (-0.48%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30312711 30168143 ✅ -144568 (-0.48%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30349423 30204748 ✅ -144675 (-0.48%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30348776 30204109 ✅ -144667 (-0.48%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30363228 30218493 ✅ -144735 (-0.48%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30726584 30585389 ✅ -141195 (-0.46%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30726464 30585374 ✅ -141090 (-0.46%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748986 30607918 ✅ -141068 (-0.46%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42245425 42081331 ✅ -164094 (-0.39%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244831 42080791 ✅ -164040 (-0.39%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42259298 42095258 ✅ -164040 (-0.39%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41798136 41640486 ✅ -157650 (-0.38%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798626 41640994 ✅ -157632 (-0.38%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41812362 41654712 ✅ -157650 (-0.38%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41710146 41570796 ✅ -139350 (-0.33%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41710636 41571286 ✅ -139350 (-0.33%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41724372 41585022 ✅ -139350 (-0.33%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42171601 42039031 ✅ -132570 (-0.31%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42172123 42039553 ✅ -132570 (-0.31%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42186068 42053498 ✅ -132570 (-0.31%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617559 7594187 ✅ -23372 (-0.31%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619703 7596368 ✅ -23335 (-0.31%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475844 11452485 ✅ -23359 (-0.20%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481800 11458465 ✅ -23335 (-0.20%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10806209 10700606 -105603 (-0.98%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10803316 10749734 -53582 (-0.50%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8566526 8598011 31485 (0.37%) 1.09%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10442198 10458375 16177 (0.15%) 1.33%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622946 3624843 1897 (0.05%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8590921 8593878 2957 (0.03%) 0.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chach 8000 a_client 3086727 3087450 723 (0.02%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084770 3085270 500 (0.02%) 0.27%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623456 3623923 467 (0.01%) 0.44%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873385 3873505 120 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3890031 3890151 120 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215739 4215859 120 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236729 4236849 120 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4250539 4250659 120 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497513 4497633 120 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4693603 4693723 120 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012105 5012225 120 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255491 58256137 646 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348106 58348752 646 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253413 58254053 640 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58351863 58352504 641 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58236458 58237089 631 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251185 58251815 630 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58340971 58341601 630 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683803 68684443 640 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717456 1717471 15 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714211 92714854 643 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92711982 92712623 641 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684031 92684671 640 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673122 92673761 639 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682195 92682833 638 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718218 92718849 631 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932692 1932688 -4 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563535 2563539 4 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925964 1925967 3 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185128 35185162 34 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292292 11292296 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470683 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389588 46389595 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487103 46487096 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641263 80641254 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434715 46434710 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467811 46467806 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467123 46467127 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535643 80535649 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661850 80661844 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480087 46480090 3 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183215 35183217 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648887 80648883 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460133 46460134 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656291 2656291 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554934 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662156 2662156 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540448 80540448 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.12 ms ⚠️ 0.04 ms (3.30%) 2.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.56 ms 4.48 ms ✅ -0.08 ms (-1.76%) 1.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.28 ms 5.19 ms ✅ -0.09 ms (-1.64%) 1.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.90 ms 4.83 ms ✅ -0.08 ms (-1.54%) 1.51%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.08 ms 1.12 ms 0.04 ms (3.65%) 8.34%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.05 ms 1.09 ms 0.03 ms (3.23%) 3.65%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.59 ms 1.64 ms 0.04 ms (2.74%) 4.94%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.81 ms 0.04 ms (2.39%) 5.09%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.10 ms 5.19 ms 0.09 ms (1.81%) 4.37%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.08 ms 5.16 ms 0.08 ms (1.67%) 4.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.58 ms 4.51 ms -0.07 ms (-1.62%) 1.88%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.22 ms -0.08 ms (-1.44%) 1.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.62 ms 5.54 ms -0.08 ms (-1.36%) 1.48%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.90 ms 4.84 ms -0.07 ms (-1.36%) 1.95%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.49 ms 0.06 ms (1.27%) 5.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.63 ms 5.56 ms -0.07 ms (-1.24%) 1.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.22 ms 0.06 ms (1.09%) 4.20%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.33 ms 6.39 ms 0.06 ms (0.91%) 3.60%
transfer_no_resume_ring_1.2_rsa_aes 6.75 ms 6.80 ms 0.05 ms (0.74%) 3.36%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.55 ms 13.65 ms 0.10 ms (0.73%) 1.55%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.88 ms 0.05 ms (0.72%) 3.07%
handshake_tickets_ring_1.3_ecdsap256_aes 6.68 ms 6.63 ms -0.05 ms (-0.71%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.55 ms 6.51 ms -0.04 ms (-0.66%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.19 ms -0.03 ms (-0.63%) 1.99%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.06 µs 502.10 µs 3.03 µs (0.61%) 3.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.43 ms 9.49 ms 0.06 ms (0.59%) 2.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 456.11 µs 458.74 µs 2.64 µs (0.58%) 4.06%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.51 ms 6.48 ms -0.04 ms (-0.57%) 1.05%
handshake_tickets_ring_1.3_rsa_aes 7.17 ms 7.13 ms -0.04 ms (-0.55%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.05 ms 7.01 ms -0.04 ms (-0.53%) 1.01%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.64 ms 6.60 ms -0.03 ms (-0.53%) 1.02%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.54 ms 5.51 ms -0.03 ms (-0.52%) 2.25%
handshake_no_resume_ring_1.3_ecdsap256_aes 502.89 µs 505.48 µs 2.59 µs (0.51%) 3.12%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.54 ms 5.52 ms -0.03 ms (-0.51%) 2.35%
handshake_tickets_ring_1.3_ecdsap384_aes 9.76 ms 9.72 ms -0.05 ms (-0.48%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.00 ms 6.97 ms -0.03 ms (-0.48%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.12 ms 7.09 ms -0.03 ms (-0.47%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 458.05 µs 460.13 µs 2.08 µs (0.45%) 4.35%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.70 ms 0.06 ms (0.44%) 1.66%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 12.99 ms 0.05 ms (0.42%) 1.76%
handshake_session_id_ring_1.3_ecdsap384_aes 9.63 ms 9.59 ms -0.04 ms (-0.42%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.96 ms 0.05 ms (0.39%) 1.95%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.20 ms 5.18 ms -0.02 ms (-0.38%) 2.46%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.72 ms 9.68 ms -0.04 ms (-0.37%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 993.61 µs 997.21 µs 3.60 µs (0.36%) 1.29%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.59 ms 9.56 ms -0.03 ms (-0.35%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 994.14 µs 997.54 µs 3.40 µs (0.34%) 1.16%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.48 ms 0.04 ms (0.33%) 1.67%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.32%) 1.99%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.09 ms 0.05 ms (0.32%) 1.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.26%) 1.68%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.26%) 2.03%
handshake_no_resume_ring_1.2_rsa_aes 990.02 µs 992.15 µs 2.14 µs (0.22%) 1.17%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.60 ms 0.01 ms (0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.14%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms -0.00 ms (-0.02%) 1.54%

Additional information

Historical results

Checkout details:
< 8000 !-- no margin wins, so we check it last and use its value if true. -->

@codecov Codecov
Copy link
codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.71%. Comparing base (b553880) to head (e02c24a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2168      +/-   ##
==========================================
- Coverage   94.72%   94.71%   -0.01%     
==========================================
  Files         102      102              
  Lines       23753    23748       -5     
==========================================
- Hits        22499    22493       -6     
- Misses       1254     1255       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

djc
djc approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cpu
cpu approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@ctz ctz force-pushed the jbp-faster-tls13-server-resumption branch from f09bead to 3a5f510 Compare October 18, 2024 13:47
djc
djc reviewed Oct 18, 2024
View reviewed changes
@ctz ctz force-pushed the jbp-faster-tls13-server-resumption branch from 3a5f510 to bee6836 Compare October 18, 2024 16:22
djc
djc reviewed Oct 18, 2024
View reviewed changes
ctz added 2 commits October 18, 2024 19:42
@ctz
Hoist up repeated computation of ResumptionMasterSecret
17518c3 
By default, we send 4 tickets.  Before this change, for each one
we recomputed `ResumptionMasterSecret`, then used it, then discarded
it (and it is a type that requires zeroisation).

Instead, hoist this into its own type, and make it once for each
set of tickets.
@ctz
server::tls13: send tickets in one flight
e02c24a
@ctz ctz force-pushed the jbp-faster-tls13-server-resumption branch from bee6836 to e02c24a Compare October 18, 2024 18:44
@ctz ctz enabled auto-merge October 18, 2024 18:46
@ctz ctz added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 9249b61 Oct 18, 2024
60 checks passed
@ctz ctz deleted the jbp-faster-tls13-server-resumption branch October 18, 2024 19:11
@djc djc mentioned this pull request Oct 27, 2024
Merged
@ctz ctz mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0