[REJECTED & ABANDONED] once_cell dependency updates (for no-std usage) #2238
Conversation
0fb7353 to
e3d763d
Compare
- specify most recent version in top-level `Cargo.toml` - remove redundant version specifier from `rustls/Cargo.toml` - specify required features in `rustls/Cargo.toml` instead of top-level `Cargo.toml` - move comment to the end of the line for `once_cell` dependency in `rustls/Cargo.toml`
e3d763d to
eae1327
Compare
There was a problem hiding this comment.
Unfortunately I am thinking that this proposal does introduce another inconsistency. This proposal specifies features required for once_cell in rustls/Cargo.toml, while features for the other dependencies are now specified in top-level Cargo.toml.
I personally feel this is the best way to specify features that are required for once_cell, which is only needed to support no-std.
In terms of opinion & feeling, I feel that it would be best to specify features for the other dependencies in the package-specific Cargo.toml, but am not so sure how hard I should press this feeling. I would like to leave this whole proposal open for discussion, I wouldn't mind if we reject this proposal in favor of some other solution to improve the consistency with these dependencies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2238 +/- ##
=======================================
Coverage 94.65% 94.65%
=======================================
Files 102 102
Lines 23917 23917
=======================================
Hits 22638 22638
Misses 1279 1279 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
I don't think we should take a separate PR for this. If #2200 has a specific lower bound it needs for once_cell, it should bump the dependency accordingly (and ideally not by requiring the latest version). |
👍
I developed the proposed changes for #2200 assuming that we should be able to use the recent updates to
Closing this for now :) P.S. I think |
Cargo.tomlrustls/Cargo.tomlrustls/Cargo.tomlinstead of top-levelCargo.tomlonce_celldependency inrustls/Cargo.tomlRATIONALE - updated:
I think this would help ensure downstream user is using the more recent version of
once_cell, as I think would be needed with the updates I proposed in PR #2200.It looks to me like
once_cellis only required forno-std, and usage may change somewhat further if PR #2200 is accepted. I was thinking that putting everything foronce_cell(except for version spec) together could help improve cohesiveness and help further preparations for PR #2200.