8000 update minimum serde & test all features w/minimum dependency versions by brody4hire · Pull Request #2241 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update minimum serde & test all features w/minimum dependency versions #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

update minimum serde & test all features w/minimum dependency versions #2241

wants to merge 1 commit into from

Conversation

brody4hire
Copy link
Contributor

rationale:

  • minimum serde version 1.0.103 is required for cargo minimal-versions --direct --ignore-private test to work (with or without --all-features option), seems to be due to issue between serde pre-1.0.103 & test(s) in rustls/src/crypto/aws_lc_rs/hpke.rs
  • test with minimum dependency versions, all features could help ensure updates like proposed PR unstable feature to support targets with no atomic pointers - REJECTED DRAFT PROPOSAL #2200 continue working with outdated dependency versions, especially for once_cell & portable-atomic

Note that while the code DOES seem to build with serde back to 1.0.0, bumping the minimum to 1.0.3 which is still 7 years old seems very reasonable to me.

@brody4hire brody4hire mentioned this pull request Nov 26, 2024
Closed
@brody4hire brody4hire force-pushed the update-minimum-serde-and-test-minver-all-features branch from f1cc964 to d3eb561 Compare November 26, 2024 03:44
@codecov Codecov
Copy link
codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (fa90405) to head (d3eb561).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2241   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         102      102           
  Lines       23917    23917           
=======================================
  Hits        22638    22638           
  Misses       1279     1279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

djc
djc reviewed Nov 26, 2024
View reviewed changes
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Nov 26, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10701889 10652330 -49559 (-0.46%) 0.97%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10499345 10453040 -46305 (-0.44%) 1.68%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8620389 8588243 -32146 (-0.37%) 0.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10715463 10688440 -27023 (-0.25%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8580255 8593908 13653 (0.16%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080790 3078411 -2379 (-0.08%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3081957 3082612 655 (0.02%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176596 1176692 96 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624641 3624869 228 (0.01%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076810 2076906 96 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253416 58255023 1607 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30427859 30427514 -345 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27861372 27861065 -307 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251176 58250535 -641 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073878 2073863 -15 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192971 28192785 -186 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28225981 28225796 -185 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30427180 30427377 197 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623329 3623310 -19 (-0.00%) 0.31%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28199820 28199677 -143 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28195949 28195820 -129 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27865685 27865562 -123 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30424148 30424022 -126 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27801684 27801575 -109 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925726 1925719 -7 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932468 1932461 -7 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28967477 28967549 72 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30384617 30384542 -75 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28886429 28886371 -58 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27805993 27806047 54 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611985 1611988 3 (0.00%) 1.07%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28889044 28888995 -49 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27858696 27858652 -44 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566470 7566460 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28967489 28967459 -30 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28222700 28222672 -28 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28229532 28229554 22 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182582 35182557 -25 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30381475 30381455 -20 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28964878 28964863 -15 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28889229 28889217 -12 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30384973 30384983 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470681 46470692 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423839 46423829 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348747 58348757 10 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27799165 27799169 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467802 46467807 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92716781 92716773 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58235173 58235169 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540448 80540443 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58191640 58191643 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255497 58255494 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341603 58341600 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389594 46389596 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456936 46456934 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464556 46464558 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487100 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641262 80641259 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661854 80661851 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682837 92682834 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92720776 92720779 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535647 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648886 80648884 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673768 92673766 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684672 92684670 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714546 92714544 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477531 46477530 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554935 80554934 -1 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40594220 40594220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40292528 40292528 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064948 42064948 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966108 41966108 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484849 41484849 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41963018 41963018 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41484771 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198148 40198148 0 (0.00%) 0.20%
handshake_t 8000 ickets_aws_lc_rs_1.2_rsa_aes_client 4214929 4214929 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41482178 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603799 41603799 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655903 2655903 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236939 4236939 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40586975 40586975 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352502 58352502 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3872695 3872695 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42062048 42062048 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40515976 40515976 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497603 4497603 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4695330 4695330 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564316 7564316 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40289595 40289595 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661768 2661768 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40512717 40512717 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613362 1613362 0 (0.00%) 1.06%
handshake_no_resume_ring_1.3_rsa_aes_server 11424773 11424773 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430729 11430729 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292386 11292386 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180652 35180652 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965918 41965918 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40202193 40202193 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40590226 40590226 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40519970 40519970 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603721 41603721 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40296573 40296573 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40195207 40195207 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3870183 3870183 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4230790 4230790 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563580 2563580 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41601128 41601128 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42065138 42065138 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717609 1717609 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174481 1174481 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020364 5020364 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.10 ms 1.11 ms 0.01 ms (0.60%) 2.91%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 459.69 µs 457.15 µs -2.53 µs (-0.55%) 3.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.46 ms -0.02 ms (-0.50%) 3.60%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 457.73 µs 455.54 µs -2.19 µs (-0.48%) 2.78%
handshake_no_resume_ring_1.3_ecdsap256_aes 506.87 µs 504.56 µs -2.31 µs (-0.46%) 2.03%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.06 ms 5.04 ms -0.02 ms (-0.40%) 3.48%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.35 ms 6.33 ms -0.02 ms (-0.38%) 2.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.12 ms 5.10 ms -0.02 ms (-0.36%) 3.10%
transfer_no_resume_ring_1.3_rsa_aes 6.85 ms 6.82 ms -0.02 ms (-0.35%) 2.67%
handshake_no_resume_ring_1.3_ecdsap256_chacha 503.46 µs 501.71 µs -1.75 µs (-0.35%) 2.39%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.74 ms -0.02 ms (-0.29%) 2.61%
handshake_no_resume_ring_1.2_rsa_aes 994.64 µs 991.95 µs -2.69 µs (-0.27%) 1.12%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.19 ms -0.01 ms (-0.27%) 3.55%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.29 ms -0.01 ms (-0.23%) 1.22%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.51 ms 9.49 ms -0.02 ms (-0.21%) 1.63%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms 0.00 ms (0.20%) 1.37%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 12.97 ms -0.03 ms (-0.20%) 1.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.96 ms 12.93 ms -0.02 ms (-0.19%) 1.25%
transfer_no_resume_ring_1.3_rsa_chacha 13.49 ms 13.46 ms -0.03 ms (-0.19%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 5.01 ms -0.01 ms (-0.19%) 1.23%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.47 ms 6.48 ms 0.01 ms (0.17%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.40 ms 6.41 ms 0.01 ms (0.16%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.60 ms 13.58 ms -0.02 ms (-0.15%) 1.17%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.15 ms 0.01 ms (0.14%) 1.03%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.13%) 1.61%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.68 ms 13.66 ms -0.02 ms (-0.13%) 1.20%
handshake_tickets_ring_1.3_ecdsap256_aes 6.52 ms 6.52 ms 0.01 ms (0.13%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.96 ms 6.97 ms 0.01 ms (0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.45 ms 6.45 ms 0.01 ms (0.11%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.10%) 1.72%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.48 ms 0.00 ms (0.10%) 1.36%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.14 ms 16.13 ms -0.02 ms (-0.10%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.95 ms 6.95 ms 0.01 ms (0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.76 ms 0.00 ms (0.09%) 1.53%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.09%) 2.44%
handshake_session_id_ring_1.3_rsa_chacha 6.89 ms 6.90 ms 0.01 ms (0.08%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.08%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 998.96 µs 998.28 µs -0.68 µs (-0.07%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.14 ms 5.14 ms 0.00 ms (0.07%) 1.43%
handshake_tickets_ring_1.3_rsa_aes 7.02 ms 7.02 ms 0.00 ms (0.07%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 998.87 µs 998.25 µs -0.62 µs (-0.06%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.66 ms 9.67 ms 0.01 ms (0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.66 ms 3.66 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.28 ms 4.28 ms 0.00 ms (0.05%) 1.04%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.93 ms 4.93 ms 0.00 ms (0.05%) 1.28%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.96 ms 4.95 ms -0.00 ms (-0.04%) 1.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.66 ms 3.66 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.61 ms 9.61 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.59 ms 9.59 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.54 ms 9.55 ms 0.00 ms (0.03%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms -0.00 ms (-0.03%) 1.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.21 ms 0.00 ms (0.03%) 1.06%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.99 ms -0.00 ms (-0.03%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.19 ms -0.00 ms (-0.02%) 1.02%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.50 ms 0.00 ms (0.01%) 1.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.17 ms 1.17 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@brod 8000 y4hire brody4hire force-pushed the update-minimum-serde-and-test-minver-all-features branch from 8d704b7 to 1fb1e38 Compare November 26, 2024 15:43
@brody4hire

This comment was marked as outdated.

Sign in to view
@brody4hire brody4hire force-pushed the update-minimum-serde-and-test-minver-all-features branch from 1fb1e38 to e45631f Compare November 26, 2024 15:45
@brody4hire
Copy link
Contributor Author

Now rebased, with job name no longer updated, please let me know if I need to do anything else for this thanks

cpu
cpu approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ctz
Copy link
Member
ctz commented Nov 26, 2024

Do we want to test at minimum versions? It seems excessive?

@cpu
Copy link
Member
cpu commented Nov 26, 2024

Do we want to test at minimum versions? It seems excessive?

I don't feel strongly. It looks like it increases the job's runtime from ~22s to ~1.5m which isn't nothing, but also dwarfed by other tasks. 🤷

@brody4hire
Copy link
Contributor Author

IMHO ideal if we can test with minimum dependencies that are supported ... I don't know how many other projects are doing this. For example, my work in PR #2200 assumes recent update to portable-atomic-util, would be nice to have a way to check that we are not allowing too-old dependency version. I remain hopeful on this, leaving open for discussion 😄

@djc
Copy link
Member
djc commented Nov 27, 2024

I don't think the check -> test transition is really worth it. IMO it's unlikely that code that compiled at an older version does not work at that version when it is known to work in the current version.

@brody4hire brody4hire closed this Nov 27, 2024
@brody4hire brody4hire deleted the update-minimum-serde-and-test-minver-all-features branch November 27, 2024 13:19
@brody4hire
Copy link
Contributor Author

Withdrawn & closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brody4hire @ctz @cpu @djc
0