docs: improve some more links, etc. #2355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 103 103
Lines 24274 24274
=======================================
Hits 23034 23034
Misses 1240 1240 ☔ View full report in Codecov by Sentry. |
a5bfa07 to
f86ed4d
Compare
CryptoProviderf86ed4d to
95a41cb
Compare
95a41cb to
4ab88b6
Compare
brody4hire
commented
Feb 25, 2025
This was referenced Feb 25, 2025
4ef4165 to
b6a0c3a
Compare
b6a0c3a to
aa460f5
Compare
|
Just a reminder that every PR or change to a PR notifies every maintainer. This PR especially has been very noisy. |
ctz
approved these changes
Feb 25, 2025
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
cpu
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STATUS: KEEPING AS DRAFT FOR NOW - KNOWN TODO ITEM(S) BELOW
CryptoProvidersectionCryptoProviderstruct, which I think is is more consitent with other parts of documentation forCryptoProvidercrypto/mod.rsthat I missed in recent other PR docs: minor improvements to CryptoProvider doc #2353crypto/mod.rsprovider-example/TODO
add more explicit reference to the manual that is referenced here & there- see PR docs: add & update refs to detailed manual etc. #2356FURTHER INVESTIGATION DEFERRED FOR NOW
(), found some methods without()for example:ServerConfig::require_ems&ClientConfig::require_emsin lib.rscrypto::signer::SigningKey::choose_schemeinmanual/howto.rsConfigBuilder::with_single_certincrypto/mod.rsRELATED UPDATES
CryptoProvideralready mergedMOVING FORWARD
My apologies for so much noise. I think this should be ready for review. A bunch of things are combined, and I would be happy to separate some of these things if needed.
I have raised some more PRs that may be related to this. I would be happy to combine or separate changes out in a different way if needed.