8000 docs: add & update refs to detailed manual etc. by brody4hire · Pull Request #2356 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: add & update refs to detailed manual etc. #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: add & update refs to detailed manual etc. #2356

wants to merge 1 commit into from

Conversation

brody4hire
Copy link
Contributor

No description provided.

@brody4hire brody4hire mentioned this pull request Feb 24, 2025
Merged
2 tasks
@codecov Codecov
Copy link
codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (4015d93) to head (de4e2ca).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2356   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files         103      103           
  Lines       24292    24292           
=======================================
  Hits        23051    23051           
  Misses       1241     1241

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

brody4hire
brody4hire commented Feb 24, 2025
View reviewed changes
@brody4hire brody4hire force-pushed the detailed-manual-updates branch from 027bca3 to c46153c Compare February 24, 2025 19:18
ctz
ctz requested changes Feb 25, 2025
View reviewed changes
@brody4hire @ctz
docs: add & update refs to detailed manual etc.
de4e2ca 
Co-authored-by: Joe Birr-Pixton <jpixton@gmail.com>
@brody4hire brody4hire force-pushed the detailed-manual-updates branch from 9bad21a to de4e2ca Compare February 25, 2025 13:46
@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10452538 10391889 -60649 (-0.58%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1150626 1146002 -4624 (-0.40%) 1.55%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10736671 10693529 -43142 (-0.40%) 1.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3085622 3082447 -3175 (-0.10%) 0.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8278398 8270463 -7935 (-0.10%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8276699 8272972 -3727 (-0.05%) 1.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10718283 10720172 1889 (0.02%) 1.34%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3300336 3300659 323 (0.01%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2059527 2059345 -182 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1143709 1143783 74 (0.01%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2062469 2062580 111 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080281 3080388 107 (0.00%) 0.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3302065 3301978 -87 (-0.00%) 0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28903059 28902831 -228 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1931069 1931084 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1297127 1297137 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28213471 28213326 -145 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30438493 30438340 -153 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28186636 28186737 101 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28190432 28190525 93 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27846479 27846411 -68 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28903065 28903134 69 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28981410 28981341 -69 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1716224 1716228 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1295746 1295749 3 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1924323 1924319 -4 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28979039 28978980 -59 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27789333 27789388 55 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27793850 27793795 -55 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28900843 28900788 -55 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28220179 28220228 49 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27853253 27853210 -43 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27786860 27786897 37 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28183659 28183693 34 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30395409 30395442 33 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30438024 30438052 28 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28216434 28216456 22 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30392841 30392856 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 34738264 34738279 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7227376 7227379 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46253815 46253825 10 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27848869 27848874 5 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28981416 28981421 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46407679 46407687 8 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30435572 30435567 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58083700 58083709 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58234443 58234452 9 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30395743 30395739 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46248376 46248382 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46458304 46458310 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58174932 58174939 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80548538 80548547 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46465925 46465930 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92669192 92669201 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92680094 92680103 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92698442 92698451 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80553345 80553339 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58075913 58075917 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58237322 58237326 4 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46148659 46148656 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80642627 80642631 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678258 92678262 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58239404 58239402 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92704691 92704688 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80541809 80541811 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46241641 46241642 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92700686 92700688 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46461268 46461267 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80645593 80645592 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2330302 2330302 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5021722 5021722 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4299668 4299668 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11134290 11134290 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 31211544 31211544 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 32263389 32263389 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 32725558 32725558 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 30827497 30827497 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3874635 3874635 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 32150619 32150619 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4557014 4557014 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764122 4764122 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 31149106 31149106 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 30912908 30912908 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 32632688 32632688 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 31145847 31145847 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 31208265 31208265 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 32630322 32630322 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3869725 3869725 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 34740197 34740197 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 32150541 32150541 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4294092 4294092 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11000054 11000054 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 30916953 30916953 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 32632498 32632498 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 30830438 30830438 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11128320 11128320 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80650252 80650252 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 32723382 32723382 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2242629 2242629 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 32261146 32261146 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57980055 57980055 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58086815 58086815 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 30834483 30834483 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 32148376 32148376 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 32725718 32725718 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4211719 4211719 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 32263311 32263311 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 31153100 31153100 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 31215538 31215538 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2336155 2336155 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 30909955 30909955 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7229547 7229547 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_ring_1.3_ecdsap384_aes 9.30 ms 9.32 ms 0.02 ms (0.24%) 3.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.52 ms 4.51 ms -0.01 ms (-0.23%) 2.36%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.00 ms 4.99 ms -0.01 ms (-0.21%) 1.76%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.33 ms 4.32 ms -0.01 ms (-0.21%) 2.26%
transfer_no_resume_ring_1.3_rsa_aes 6.68 ms 6.69 ms 0.01 ms (0.19%) 4.13%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.96 ms 4.95 ms -0.01 ms (-0.19%) 1.30%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.60 ms 0.01 ms (0.19%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.31 ms 4.30 ms -0.01 ms (-0.18%) 2.01%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.16 ms -0.01 ms (-0.18%) 1.64%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.98 ms 4.97 ms -0.01 ms (-0.18%) 2.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.97 ms 4.96 ms -0.01 ms (-0.18%) 1.58%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.13 ms 1.13 ms 0.00 ms (0.17%) 1.48%
handshake_no_resume_ring_1.3_ecdsap256_chacha 470.79 µs 470.03 µs -0.76 µs (-0.16%) 3.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.18 ms 5.17 ms -0.01 ms (-0.16%) 1.59%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.02 ms 16.04 ms 0.03 ms (0.16%) 1.86%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.19 ms 6.20 ms 0.01 ms (0.15%) 4.71%
transfer_no_resume_ring_1.2_rsa_aes 6.60 ms 6.61 ms 0.01 ms (0.14%) 3.70%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.59 ms 3.60 ms 0.00 ms (0.14%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 5.51 ms 5.51 ms -0.01 ms (-0.14%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.16 ms 5.16 ms -0.01 ms (-0.13%) 2.08%
handshake_session_id_ring_1.3_rsa_chacha 6.01 ms 6.00 ms -0.01 ms (-0.13%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.13%) 2.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.10 ms 1.11 ms 0.00 ms (0.12%) 1.85%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.20 ms -0.01 ms (-0.12%) 1.71%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.50 ms 4.50 ms -0.00 ms (-0.11%) 1.76%
handshake_tickets_ring_1.3_rsa_aes 6.12 ms 6.12 ms -0.01 ms (-0.11%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 963.00 µs 963.92 µs 0.92 µs (0.10%) 1.25%
transfer_no_resume_ring_1.3_rsa_chacha 13.39 ms 13.40 ms 0.01 ms (0.09%) 2.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.14 ms 1.14 ms 0.00 ms (0.09%) 1.23%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.78 ms 1.79 ms 0.00 ms (0.09%) 3.29%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.90 ms 12.92 ms 0.01 ms (0.09%) 2.21%
handshake_tickets_ring_1.3_ecdsap256_chacha 5.58 ms 5.58 ms -0.00 ms (-0.09%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.43 ms 0.00 ms (0.08%) 6.35%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.00 ms (0.08%) 1.42%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.89 ms 12.90 ms 0.01 ms (0.08%) 2.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 448.59 µs 448.26 µs -0.33 µs (-0.07%) 4.32%
handshake_session_id_ring_1.3_rsa_aes 6.06 ms 6.05 ms -0.00 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.07 ms 6.07 ms -0.00 ms (-0.06%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 5.56 ms 5.55 ms -0.00 ms (-0.06%) 1.05%
handshake_tickets_ring_1.3_ecdsap384_aes 8.74 ms 8.74 ms 0.00 ms (0.06%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.01 ms 5.01 ms 0.00 ms (0.05%) 6.38%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.58 ms 13.59 ms 0.01 ms (0.05%) 2.20%
handshake_no_resume_ring_1.2_rsa_aes 959.42 µs 959.89 µs 0.47 µs (0.05%) 1.67%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.05%) 4.12%
handshake_session_id_ring_1.3_ecdsap384_aes 8.67 ms 8.67 ms 0.00 ms (0.05%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.12 ms 5.12 ms 0.00 ms (0.04%) 5.57%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.62 ms -0.00 ms (-0.04%) 2.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.55 ms 13.56 ms 0.01 ms (0.04%) 2.51%
handshake_session_id_ring_1.3_ecdsap384_chacha 8.63 ms 8.63 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 450.46 µs 450.57 µs 0.11 µs (0.03%) 4.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 473.56 µs 473.62 µs 0.06 µs (0.01%) 2.88%
handshake_tickets_ring_1.3_ecdsap256_aes 5.63 ms 5.63 ms -0.00 ms (-0.01%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.01%) 1.10%
handshake_no_resume_ring_1.3_rsa_chacha 964.93 µs 965.00 µs 0.08 µs (0.01%) 1.39%
handshake_tickets_ring_1.3_ecdsap384_chacha 8.69 ms 8.69 ms 0.00 ms (0.00%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.08 ms 5.08 ms 0.00 ms (0.00%) 6.36%

Additional information

Historical results

Checkout details:

cpu
cpu reviewed Feb 26, 2025
View reviewed changes
rustls/src/lib.rs
@@ -266,6 +266,10 @@
//!
//! [`mio`]: https://docs.rs/mio/latest/mio/
//!
//! # Detailed manual
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "detailed"? It seems a bit superfluous to me. Why not just refer to it as the manual?

8A93

@ctz ctz mentioned this pull request Mar 11, 2025
Merged
@ctz ctz closed this in #2375 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu left review comments

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brody4hire @cpu @ctz
0