[air] Add _max_cpu_fraction_per_node to ScalingConfig and documentation #26634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
commented
Jul 16, 2022
| tune.run(trainer.as_trainable(), num_samples=4) | ||
|
|
||
|
|
||
| # TODO(ekl/sang) this currently fails. |
There was a problem hiding this comment.
@rkooo567 , it seems this fails since all CPUs end up excluded. Can we ensure at least 1 CPU is available on either side no matter how aggressive the fraction is?
Btw, I think we should disallow 1.0 and 0.0 as values (raise ValueError).
matthewdeng
approved these changes
Jul 17, 2022
doc/source/data/key-concepts.rst
Outdated
Comment on lines
162
to
163
| ``_max_cpu_fraction_per_node`` is experimental and not recommended for use with | ||
| autoscaling clusters. |
There was a problem hiding this comment.
Should we be more explicit and say that the reason is that doing so may cause deadlock?
richardliaw
reviewed
Jul 17, 2022
scv119
approved these changes
Jul 17, 2022
richardliaw
approved these changes
Jul 17, 2022
jianoaix
pushed a commit
to jianoaix/ray
that referenced
this pull request
Jul 18, 2022
…on (ray-project#26634) Signed-off-by: Ubuntu <ubuntu@ip-172-31-32-136.us-west-2.compute.internal>
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
…on (ray-project#26634) Signed-off-by: Xiaowei Jiang <xwjiang2010@gmail.com>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…on (ray-project#26634) Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
As a followup for #26397, add this to the docs and API as an experimental feature.