[air] Add a warning if no CPUs are reserved for dataset execution #26643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericl
commented
Jul 17, 2022
| return ScalingConfigDataClass( | ||
| trainer_resources=trainer_resources, | ||
| num_workers=num_workers, | ||
| use_gpu=use_gpu, | ||
| resources_per_worker=resources_per_worker, | ||
| placement_strategy=placement_strategy, | ||
| _max_cpu_fraction_per_node=max_cpu_fraction_per_node, |
There was a problem hiding this comment.
Bug where this wasn't propagated to copies of the Trainer. Didn't affect correctness, but broke the warning.
Signed-off-by: Eric Liang <ekhliang@gmail.com>
matthewdeng
approved these changes
Jul 17, 2022
jianoaix
approved these changes
Jul 17, 2022
jianoaix
pushed a commit
to jianoaix/ray
that referenced
this pull request
Jul 18, 2022
…y-project#26643) Signed-off-by: Ubuntu <ubuntu@ip-172-31-32-136.us-west-2.compute.internal>
xwjiang2010
pushed a commit
to xwjiang2010/ray
that referenced
this pull request
Jul 19, 2022
…y-project#26643) Signed-off-by: Xiaowei Jiang <xwjiang2010@gmail.com>
Stefan-1313
pushed a commit
to Stefan-1313/ray_mod
that referenced
this pull request
Aug 18, 2022
…y-project#26643) Signed-off-by: Stefan van der Kleij <s.vanderkleij@viroteq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Liang ekhliang@gmail.com
Why are these changes needed?
This is a followup for #26634