Include context about what object caused the exception in OT #6203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
reviewed
Jan 17, 2023
src/realm/sync/transform.cpp
Outdated
| throw_bad_merge(util::format(msg, std::forward<Params>(params)...)); | ||
| } | ||
|
|
||
| REALM_NORETURN void bad_merge(_impl::TransformerImpl::Side& side, Instruction::ObjectInstruction instr, |
There was a problem hiding this comment.
Do we want to have a bad_merge for PathInstructions too and log which property/path was being touched?
There was a problem hiding this comment.
Done. It turns out that they were all PathInstruction's anyway.
jbreams
approved these changes
Jan 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
We provide context about the objects causing exceptions when the instructions are applied, but there is no such information when exceptions occur during OT. This PR adds the table name and primary key value of the object in cause.
Fixes #6204.
☑️ ToDos
🚦 Tests (or not relevant)C-API, if public C++ API changed.