Fix bug caused by not returning accumulator if presence isn't included in the validation definition #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in the validation definition
|
I think this fix was applied previously: #12 But it appears to have been lost during a later refactoring. |
rewinfrey
reviewed
Jun 7, 2022
There was a problem hiding this comment.
@MatthewRDodds thank you for the patch! ❤️ Nice find and debugging. I'm not sure what happened, but you're right the fix was dropped somehow. I must have cut a bad release and dropped it by accident. If you're okay with the suggestion I'm happy to merge.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When some validations include the presence key and others do not, this error is raised:
It's because the accumulator is not returned for those validation expectations that don't include the
presencekey. So in the iteration following such a definition,error_collectionisnil.