8000 Fixing Error Received When First Validator is a Custom Presence Validator by knittingdev · Pull Request #12 · rewinfrey/ActionLogic · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixing Error Received When First Validator is a Custom Presence Validator #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

Fixing Error Received When First Validator is a Custom Presence Validator #12

merged 1 commit into from
Dec 18, 2018

Conversation

knittingdev
Copy link
Contributor

Received <NoMethodError: undefined method 'any?' for nil:NilClass> when
validating with a presence validator before a type validator was
defined. This was because the reduction within the type validators did
not return the collection on next.

Fixing Error Received When First Validator is a Custom Presence Vali…
57fd2df 
…dator

    Received <NoMethodError: undefined method 'any?' for nil:NilClass> when
    validating with a presence validator before a type validator was
    defined. This was because the reduction within the type validators did
    not return the collection on 'next'.
rewinfrey
rewinfrey approved these changes Dec 18, 2018
View reviewed changes
Copy link
Owner
@rewinfrey rewinfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knittingdev thank you for this patch! This looks 👍 Thank you also for the additional test cases 🙇

@rewinfrey rewinfrey merged commit 114570e into rewinfrey:master Dec 18, 2018
rewinfrey added a commit that referenced this pull request Dec 18, 2018
@rewinfrey
Bump to version 0.3.0
9d39ec5 
Based on @knittingdev's excellent patch #12
@MatthewRDodds MatthewRDodds mentioned this pull request Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rewinfrey rewinfrey rewinfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knittingdev @rewinfrey
0