8000 fix(ci): fix rust toolchain by kwannoel · Pull Request #20728 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(ci): fix rust toolchain #20728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix(ci): fix rust toolchain #20728

merged 1 commit into from
Mar 5, 2025

Conversation

kwannoel
Copy link
Contributor
@kwannoel kwannoel commented Mar 5, 2025 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Prefix the install command everywhere there's rustup show called

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Mar 5, 2025
@kwannoel kwannoel requested review from cyliu0 and xxchan March 5, 2025 07:36
@kwannoel kwannoel added need-cherry-pick-release-2.1 [⚠️DEPRECATED] Use `..-since-release-..` instead need-cherry-pick-release-2.2 [⚠️DEPRECATED] Use `..-since-release-..` instead need-cherry-pick-release-2.3 [⚠️DEPRECATED] Use `..-since-release-..` instead labels Mar 5, 2025
xxchan
xxchan approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member
@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@cyliu0 cyliu0 enabled auto-merge March 5, 2025 07:45
@cyliu0 cyliu0 added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit c77e815 Mar 5, 2025
46 of 48 checks passed
@cyliu0 cyliu0 deleted the kwannoel/rust-toolchain branch March 5, 2025 08:18
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
@kwannoel
fix(ci): fix rust toolchain (#20728)
7682d0c
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
@kwannoel
fix(ci): fix rust toolchain (#20728)
644573a
@github-actions github-actions bot mentioned this pull request Mar 5, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2025
@github-actions @kwannoel
fix(ci): fix rust toolchain (#20728) (#20729)
3dc0d78 
Co-authored-by: Noel Kwan <47273164+kwannoel@users.noreply.github.com>
@BugenZhao
Copy link
Member
BugenZhao commented Mar 5, 2025 •
edited
Loading

Rustup will restore the auto installation functionality in an upcoming release of v1.28.1 (rust-lang/rustup#4223, rust-lang/rustup#4219) 🤡.

Perhaps we can consider revert relevant PRs (including this one and #20718) soon.

@ClSlaid
Copy link
Contributor
ClSlaid commented Mar 5, 2025 •
edited
Loading

Perhaps we can consider revert relevant PRs (including this one and #20718) soon.

We can just keep this PR, if I considered it right, Rustup will only remind us that we have already got the tool chain installed.

rustup toolchain install
#info: using existing install for 'nightly-2025-03-05-aarch64-apple-darwin'
#info: the active toolchain `nightly-2025-03-05-aarch64-apple-darwin` has been installed
#info: it's active because: overridden by '/Users/cl/RwProjects/risingwave/rust-toolchain'

And the reason why we already have a rustup show here is obvious, we've been installing tool chains with its side effect. And now it's gone accidentally, so we have to install manually.

github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2025
@github-actions @kwannoel
fix(ci): fix rust toolchain (#20728) (#20730)
987ef88 
Co-authored-by: Noel Kwan <47273164+kwannoel@users.noreply.github.com>
@xiangjinwu
Copy link
Contributor

https://github.com/risingwavelabs/risingwave/actions/workflows/doc.yml

Run rustup toolchain install --profile minimal && rustup show
  rustup toolchain install --profile minimal && rustup show
  shell: /usr/bin/bash -e {0}
  env:
    SCCACHE_GHA_ENABLED: true
    RUSTC_WRAPPER: sccache
    RUSTDOCFLAGS: --markdown-css rust.css --markdown-no-toc --index-page /home/runner/work/risingwave/risingwave/docs/rustdoc/index.md -Zunstable-options
error: error: the following required arguments were not provided:
  <toolchain>...

Usage: rustup toolchain install --profile <profile> <toolchain>...

For more information, try '--help'.

Error: Process completed with exit code 1.

@kwannoel kwannoel mentioned this pull request Mar 11, 2025
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyliu0 cyliu0 cyliu0 approved these changes

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
need-cherry-pick-release-2.1 [⚠️DEPRECATED] Use `..-since-release-..` instead need-cherry-pick-release-2.2 [⚠️DEPRECATED] Use `..-since-release-..` instead need-cherry-pick-release-2.3 [⚠️DEPRECATED] Use `..-since-release-..` instead type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kwannoel @BugenZhao @ClSlaid @xiangjinwu @cyliu0 @xxchan
0