8000 feat(foyer): cherry-pick disk cache optimization related PRs by MrCroxx · Pull Request #21844 · risingwavelabs/risingwave · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(foyer): cherry-pick disk cache optimization related PRs #21844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2025
Merged

feat(foyer): cherry-pick disk cache optimization related PRs #21844

merged 4 commits into from
May 14, 2025

Conversation

MrCroxx
Copy link
Contributor
@MrCroxx MrCroxx commented May 13, 2025

Signed-off-by: MrCroxx mrcroxx@outlook.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Cherry-pick populated entries disk cache insertion optimization related PRs.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

MrCroxx added 3 commits May 13, 2025 15:01
@MrCroxx
feat(foyer): bump foyer version for advanced io throttling (#21406)
08e1c42 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
feat: cherry-pick #21573 #21840 for populated entry optimization
5f040c3 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
feat(foyer): add config field to set file cache fifo probation ratio (#…
a730e2e 
…21841)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this May 13, 2025
@MrCroxx MrCroxx requested a review from a team as a code owner May 13, 2025 07:38
@MrCroxx MrCroxx requested review from wenym1 and removed request for a team May 13, 2025 07:38
@github-actions github-actions bot added the type/feature Type: New feature. label May 13, 2025
@MrCroxx MrCroxx requested review from hzxa21, Li0k and kwannoel May 13, 2025 08:59
Li0k
Li0k approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor
@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrCroxx MrCroxx mentioned this pull request May 14, 2025
Merged
3 tasks
@MrCroxx
fix: fix disk cache wrong result on hash collision
b6187c9 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx force-pushed the xx/patch/hcb-2.2.5 branch from 7022920 to b6187c9 Compare May 14, 2025 07:55
@MrCroxx
Copy link
Contributor Author
MrCroxx commented May 14, 2025

Flaky test #21866 . Merge.

@MrCroxx MrCroxx merged commit 5c0e1a9 into patch/hcb-2.2.5 May 14, 2025
22 of 27 checks passed
@MrCroxx MrCroxx deleted the xx/patch/hcb-2.2.5 branch May 14, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxa21 hzxa21 hzxa21 approved these changes

@Li0k Li0k Li0k approved these changes

@kwannoel kwannoel kwannoel approved these changes

@wenym1 wenym1 Awaiting requested review from wenym1 wenym1 is a code owner automatically assigned from risingwavelabs/cargo-lock

Assignees

@MrCroxx MrCroxx

Labels
type/feature Type: New feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrCroxx @hzxa21 @Li0k @kwannoel
0