Add destroy objects during save #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bae152a to
dc49923
Compare
grosendo2006
commented
Jul 8, 2024
santib
reviewed
Jul 8, 2024
santib
reviewed
Jul 8, 2024
| end | ||
|
|
||
| it 'returns false' do | ||
| expect(subject).to eq false |
There was a problem hiding this comment.
interesting, wondering why is it even returning false
There was a problem hiding this comment.
I think it's because the way I'm initializating the user, I'm not setting the name so it's returning this error
<ActiveModel::Errors [#<ActiveModel::NestedError attribute=name, type=blank, options={}>]>>
def user
@user ||= User.find_or_initialize_by(email: email)
end
santib
approved these changes
Jul 8, 2024
dc49923 to
3b565b6
Compare
|
Do any of these changes fix our open issues? @santib you opened those issues, but they don't have a description |
no, they are unrelated |
|
Great improvement! Thanks 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While using this gem, we noticed that if want to delete some models, we don't have a way unless they have a direct relationship (you can see an example here)
So, the idea of this PR is to add the possibility to delete some models using mark_for_destruction, similar to the way rails does with his associations
Other Information