rootstrap · santib · Jul 8, 2024 · Jul 8, 2024
diff --git a/.reek.yml b/.reek.yml
@@ -23,7 +23,9 @@ detectors:
     allow_calls: []
   FeatureEnvy:
     enabled: true
-    exclude: ['YAAF::Form#promote_legacy_errors']
+    exclude: 
+      - 'YAAF::Form#promote_legacy_errors'
+      - 'YAAF::Form#save_models'
   InstanceVariableAssumption:
     enabled: false
   IrresponsibleModule:

diff --git a/lib/yaaf/form.rb b/lib/yaaf/form.rb
@@ -52,7 +52,9 @@ def save_in_transaction(options)
     def save_models(options)
       options.merge!(validate: false)
 
-      models.map { |model| model.save!(**options) }
+      models.map do |model|
+        model.marked_for_destruction? ? model.destroy! : model.save!(**options)
+      end
     end
 
     def validate_models

diff --git a/spec/support/forms.rb b/spec/support/forms.rb
@@ -7,3 +7,4 @@
 require_relative 'forms/with_validation_callbacks_form'
 require_relative 'forms/with_callback_exception_raising'
 require_relative 'forms/custom_transaction_form'
+require_relative 'forms/user_destroy_form'
diff --git a/spec/support/forms/user_destroy_form.rb b/spec/support/forms/user_destroy_form.rb
@@ -0,0 +1,21 @@
+class UserDestroyForm < YAAF::Form
+  attr_accessor :email, :name
+
+  before_save :mark_user_for_destruction
+
+  def initialize(args)
+    super(args)
+
+    @models = [user]
+  end
+
+  def user
+    @user ||= User.find_or_initialize_by(email: email)
+  end
+
+  private
+
+  def mark_user_for_destruction
+    user.mark_for_destruction
+  end
+end
diff --git a/spec 10000 /yaaf/user_destroy_form_spec.rb b/spec 10000 /yaaf/user_destroy_form_spec.rb
@@ -0,0 +1,101 @@
+# frozen_string_literal: true
+
+RSpec.describe 'UserDestroyForm form' do
+  let(:user_destroy_form) { UserDestroyForm.new(args) }
+  let(:args) do
+    { email: 'test@example.com', name: 'John' }
+  end
+  let(:user_args) { args }
+  let!(:user) { User.create(user_args) }
+
+  describe '#save' do
+    subject { user_destroy_form.save }
+
+    context 'when the user exists' do
+      before do
+        expect(user_destroy_form).to be_valid
+      end
+
+      it 'returns true' do
+        expect(subject).to eq true
+      end
+
+      it 'deletes the user' do
+        expect { subject }.to change { User.count }.by(-1)
+      end
+    end
+
+    context 'when the user doesn\'t exist' do
+      let(:user_args) do
+        { email: 'another@email.com', name: 'John' }
+      end
+
+      it 'returns false' do
+        expect(subject).to eq false
+      end
+
+      it 'doesn\'t delete the user' do
+        expect { subject }.not_to change { User.count }
+      end
+    end
+  end
+
+  describe '#save!' do
+    subject { user_destroy_form.save! }
+
+    context 'when the user exists' do
+      before do
+        expect(user_destroy_form).to be_valid
+      end
+
+      it 'returns true' do
+        expect(subject).to eq true
+      end
+
+      it 'deletes the user' do
+        expect { subject }.to change { User.count }.by(-1)
+      end
+    end
+
+    context 'when the user doesn\'t exist' do
+      let(:user_args) do
+        { email: 'another@email.com', name: 'John' }
+      end
+
+      it 'raises an exception' do
+        expect { subject }.to raise_error(ActiveModel::ValidationError)
+      end
+
+      it 'doesn\'t delete the user' do
+        expect { subject rescue nil }.not_to change { User.count }
+      end
+    end
+  end
+
+  describe '#valid?' do
+    subject { user_destroy_form.valid? }
+
+    it { is_expected.to be true }
+  end
+
+  describe '#invalid?' do
+    subject { user_destroy_form.invalid? }
+
+    it { is_expected.to be false }
+  end
+
+  describe '#errors' do
+    subject do
+      user_destroy_form.valid?
+      user_destroy_form.errors
+    end
+
+    it 'returns the correct class' do
+      expect(subject.class).to eq(ActiveModel::Errors)
+    end
+
+    it 'is empty' do
+      expect(subject.messages).to be_empty
+    end
+  end
+end