Update to #24 8000 to limit mismatches for org pages #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the repository matches the org name, which might be slightly more common for small OSS projects where the owner wishes to move to using an org to allow it be managed by other contributors over time, the existing code will assume this means it is for the org level pages. Consequently updates to a repo such as vagrant-libvirt/vagrant-libvirt will have it's preview URL using the org style rather than the repository style. This change adjust the matching to limit to only allowing repos of the name `<org>.github.io` to be presented with the org style gh-pages preview URL. Fixes: rossjrw#39
|
Thanks @electrofelix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the repository matches the org name, which might be slightly more
common for small OSS projects where the owner wishes to move to using an
org to allow it be managed by other contributors over time, the existing
code will assume this means it is for the org level pages.
Consequently updates to a repo such as vagrant-libvirt/vagrant-libvirt
will have it's preview URL using the org style rather than the
repository style.
This change adjust the matching to limit to only allowing repos of the
name
<org>.github.ioto be presented with the org style gh-pagespreview URL.
Fixes #39