Add argument for custom domain #24
Conversation
|
Had a chance to look at this again. I've inverted the URL setting so custom url always takes priority if it's set. |
|
Thanks @dan-hanlon, I appreciate your effort! I'll take a thorough look at this when I get the chance. |
There was a problem hiding this comment.
Hi @rossjrw. I'm just doing a passing review, as I would also love to use this feature.
The implementation in this PR definitely looks like it would solve my use case. I love the idea of automatically checking the CNAME file in the repo, but I also don't mind having to specify the domain in the workflow if that means we can get it sooner.
|
Thanks @voracious, appreciate your input. Agreed, this does look solid. I've added a spot of documentation. Let me know how this works for you @voracious @dan-hanlon? |
|
Hey @rossjrw. I'm trying to verify this, but my workflow isn't picking up |
|
To follow up, it looks like it works correctly when explicitly setting the version to |
|
Agh! Silly me - I pushed v1.3.0 but forgot to update v1 (and add v1.3). I'll get onto that... |
|
Ah, that explains it. Thanks so much for releasing this. It's been working well for the past week. |
When the repository matches the org name, which might be slightly more common for small OSS projects where the owner wishes to move to using an org to allow it be managed by other contributors over time, the existing code will assume this means it is for the org level pages. Consequently updates to a repo such as vagrant-libvirt/vagrant-libvirt will have it's preview URL using the org style rather than the repository style. This change adjust the matching to limit to only allowing repos of the name `<org>.github.io` to be presented with the org style gh-pages preview URL. Fixes: rossjrw#39
Update to #24 to limit mismatches for org pages
I saw this was an issue for others as well (#12) so thought I'd look at trying to implement it.
This seems like it should work for me but I'm not an expert on Github Actions. It adds an optional argument for a custom URL, if the argument is empty it should be ignored, if it is set it should overwrite the pages URL.
I haven't tested it comprehensively yet but wanted to get feedback on if this is the right direction.