-
Notifications
You must be signed in to change notification settings - Fork 219
Add the fmt_duration()
function
#916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
reviewed
Mar 25, 2022
jcheng5
reviewed
Mar 25, 2022
jcheng5
reviewed
Mar 25, 2022
jcheng5
reviewed
Mar 25, 2022
jcheng5
reviewed
Mar 29, 2022
jcheng5
reviewed
Mar 29, 2022
jcheng5
reviewed
Mar 29, 2022
* master: (30 commits) Update documentation `devtools::document()` (GitHub Actions) Improve layout of examples in documentation (#933) Update _pkgdown.yml Rename as `fmt_partsper()`; refactor Add several testthat tests Make corrections/additions to RTF marks Update help files using roxygen Update documentation Update help files using roxygen Update _pkgdown.yml Update NAMESPACE Rename function Renumber formatter functions Update _pkgdown.yml Update fmt_per.Rd Update format_data.R Update fmt_per.Rd Update format_data.R Improve regex for per mille|myriad in LaTeX output ...
cscheid
reviewed
Jul 8, 2022
cscheid
previously approved these changes
Jul 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from that one comment, lgtm.
cscheid
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
fmt_duration()
function for formatting input values to time durations whether those input values are numbers or of thedifftime
class. We can specify which time units any numeric input values have (as days, hours, minutes, or seconds) and the output can be customized with a duration style (corresponding to short, long, and colon-separated forms) and a choice of output units from weeks to seconds.Fixes: #403