8000 Add the `fmt_duration()` function by rich-iannone · Pull Request #916 · rstudio/gt · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add the fmt_duration() function #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 69 commits into from
Jul 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
59e7a10
Add beginnings of `fmt_duration()`
rich-iannone Mar 24, 2022
59f47b7
Complete first pass of `fmt_duration()`
rich-iannone Mar 24, 2022
5bb4fa0
Update fmt_duration.Rd
rich-iannone Mar 24, 2022
d747198
Update _pkgdown.yml
rich-iannone Mar 24, 2022
0879d2f
Update format_data.R
rich-iannone Mar 25, 2022
a505bb8
Update fmt_duration.Rd
rich-iannone Mar 25, 2022
9221c89
Update format_data.R
rich-iannone Mar 25, 2022
d9e1d6e
Create test-fmt_duration.R
rich-iannone Mar 25, 2022
cbb904f
Make changes based on code review
rich-iannone Mar 29, 2022
0c997bc
Rewrite `fmt_duration()`
rich-iannone Mar 31, 2022
4b2a21b
Update fmt_duration.Rd
rich-iannone Mar 31, 2022
2b8030d
Update test-fmt_duration.R
rich-iannone Mar 31, 2022
1506208
Update format_data.R
rich-iannone Mar 31, 2022
62e9cb6
Update fmt_duration.Rd
rich-iannone Mar 31, 2022 8000
b60de48
Update test-fmt_duration.R
rich-iannone Mar 31, 2022
55c89ef
Update .Rbuildignore
rich-iannone Mar 31, 2022
1cf2935
Update test-fmt_duration.R
rich-iannone Mar 31, 2022
8d4e596
Merge branch 'master' into fmt-duration
rich-iannone Mar 31, 2022
7f9eb6f
Update format_data.R
rich-iannone Mar 31, 2022
8647a38
Update fmt_duration.Rd
rich-iannone Mar 31, 2022
f5f7b97
Update test-fmt_duration.R
rich-iannone Mar 31, 2022
01cb529
Create internal `durations` dataset
rich-iannone Apr 1, 2022
9dcb817
Update sysdata.rda
rich-iannone Apr 1, 2022
426ea7b
Format durations accurately in non-`en` locales
rich-iannone Apr 1, 2022
55303ee
Update test-fmt_duration.R
rich-iannone Apr 1, 2022
37c151e
Refactor `fmt_duration()`
rich-iannone Apr 4, 2022
0fb39f3
Update test-fmt_duration.R
rich-iannone Apr 4, 2022
ea589d8
Handle values of the difftime class
rich-iannone Apr 5, 2022
ab0485d
Add several testthat tests
rich-iannone Apr 5, 2022
642a929
Add length check to validation function
rich-iannone Apr 5, 2022
5427104
Modify conditional in `fmt_duration()`
rich-iannone Apr 5, 2022
14f4724
Update test-fmt_duration.R
rich-iannone Apr 5, 2022
a36cdd0
Incorporate forcing of sign in `fmt_duration()`
rich-iannone Apr 8, 2022
a0f64e5
Refine formatting of colon-separated durations
rich-iannone Apr 8, 2022
edd6625
Update test-fmt_duration.R
rich-iannone Apr 8, 2022
6401df4
Use fixed `dec_mark` val that won't conflict
rich-iannone Apr 8, 2022
2d39a68
Update test-fmt_duration.R
rich-iannone Apr 8, 2022
582449f
Add example to docs for `fmt_duration()`
rich-iannone Apr 8, 2022
2457e2f
Update docs for `fmt_duration()`
rich-iannone Apr 8, 2022
42ccdac
Use `paste0()` instead of modifying `pattern`
rich-iannone Apr 13, 2022
8419ed7
Do not add/use names in values
rich-iannone Apr 13, 2022
f7eabe8
Use df to contain time parts
rich-iannone Apr 13, 2022
01ada09
Incorporate custom colon-sep formatting
rich-iannone Apr 15, 2022
2d8a5e9
Update test-fmt_duration.R
rich-iannone Apr 15, 2022
984aa4d
Update test-fmt_duration.R
rich-iannone Apr 15, 2022
21d3fbc
Refactor `values_to_durations()`
rich-iannone Apr 15, 2022
9d17401
Make refactoring changes during code review
rich-iannone Apr 15, 2022
0821038
Merge branch 'master' into fmt-duration
rich-iannone Apr 19, 2022
70f9ba6
Merge branch 'master' into fmt-duration
rich-iannone Apr 22, 2022
782e5cb
Merge branch 'master' into fmt-duration
rich-iannone Apr 22, 2022
004626d
Merge branch 'master' into fmt-duration
rich-iannone Apr 27, 2022
e3113da
Update help files
rich-iannone Apr 27, 2022
d62d45f
Merge branch 'master' into fmt-duration
rich-iannone May 3, 2022
a9eb3f3
Merge branch 'master' into fmt-duration
rich-iannone May 3, 2022
1dd5dd8
Merge branch 'master' into fmt-duration
rich-iannone May 4, 2022
8c306eb
Merge branch 'master' into fmt-duration
rich-iannone Jun 25, 2022
c8730d8
`devtools::document()` (GitHub Actions)
rich-iannone Jun 25, 2022
1f4a7cd
Merge branch 'master' into fmt-duration
rich-iannone Jul 7, 2022
6766d22
Merge branch 'master' into fmt-duration
rich-iannone Jul 7, 2022
a1755dc
Merge branch 'master' into fmt-duration
rich-iannone Jul 7, 2022
8c04fea
Create man_fmt_duration_1.png
rich-iannone Jul 7, 2022
cdec7ba
Update format_data.R
rich-iannone Jul 7, 2022
c9e4da3
Update format_data.R
rich-iannone Jul 7, 2022
8d29e55
Update fmt_duration.Rd
rich-iannone Jul 7, 2022
7f7325e
Update fmt.Rd
rich-iannone Jul 7, 2022
326d7f8
Delete man_fmt_duration_1.png
rich-iannone Jul 7, 2022
fef6059
Update fmt_duration.md
rich-iannone Jul 7, 2022
ff47714
Update format_data.R
rich-iannone Jul 7, 2022
746864c
Add note about data generation
rich-iannone Jul 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ tests/testthat/test-as_raw_html.R
tests/testthat/test-as_word.R
tests/testthat/test-cols_width_rtf.R
tests/testthat/test-data_color.R
tests/testthat/test-fmt_duration.R
tests/testthat/test-fmt_fraction.R
tests/testthat/test-fmt_ratio.R
tests/testthat/test-footer.R
Expand Down
1 change: 1 addition & 0 deletions NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export(fmt_bytes)
export(fmt_currency)
export(fmt_date)
export(fmt_datetime)
export(fmt_duration)
export(fmt_engineering)
export(fmt_fraction)
export(fmt_integer)
Expand Down
Loading
0