Fix B2C UI memory leak #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidal-stytch
approved these changes
May 14, 2025
Code Coverage
|
jhaven-stytch
added a commit
that referenced
this pull request
May 15, 2025
* Update error types from API workflow (#298) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Update error types from API workflow (#299) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Update error types from API workflow (#300) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Update error types from API workflow (#301) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Fix B2C UI memory leak (#303) * Add Biometrics To The Consumer Prebuilt UI (#302) * WIP: initial pass, get flows working * Revisions per designs * Extract string resources * Standardize option name with iOS * Lint and update tests * Fix ui test * Update all string keys --------- Co-authored-by: ci-stytch <72180218+ci-stytch@users.noreply.github.com> Co-authored-by: Stytch Codegen Bot <support@stytch.com>
jhaven-stytch
added
9D28
a commit
that referenced
this pull request
May 16, 2025
* SDK-2657 Move all UI strings into string resources to prepare for BYOC (#296) * Rename all b2c strings, extract some that are shared, add helper for style annotations in string resources and verify it works in b2c UI * Extract all b2b ui strings from views (still need to figure out error messages) * All hardcoded strings are now resources * Update tests * Run all tests on ALL PRs/pushes, not just to main * Maybe a little overzealous * Lint * WIP: initial pass, get flows working * Revisions per designs * Extract string resources * SDK-2658 Audit string keys for BYOC MVP (#306) * Update error types from API workflow (#298) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Update error types from API workflow (#299) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Update error types from API workflow (#300) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Update error types from API workflow (#301) Co-authored-by: Stytch Codegen Bot <support@stytch.com> * Fix B2C UI memory leak (#303) * Add Biometrics To The Consumer Prebuilt UI (#302) * WIP: initial pass, get flows working * Revisions per designs * Extract string resources * Standardize option name with iOS * Lint and update tests * Fix ui test * Update all string keys --------- Co-authored-by: ci-stytch <72180218+ci-stytch@users.noreply.github.com> Co-authored-by: Stytch Codegen Bot <support@stytch.com> * SDK-2660 Add localization instructions/readme (#309) * Add localization instructions/readme * Link to Localization from main README * Update localization readme * Version bump --------- Co-authored-by: ci-stytch <72180218+ci-stytch@users.noreply.github.com> Co-authored-by: Stytch Codegen Bot <support@stytch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected a potential memory leak in B2C prebuilt UI if launched multiple times. Instead of using the callback form for listening to user changes, instead collect changes with lifecycle awareness.