8000 Pre-Built UI L10N/I18N/BYOC by jhaven-stytch · Pull Request #310 · stytchauth/stytch-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Pre-Built UI L10N/I18N/BYOC #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 16, 2025
Merged

Pre-Built UI L10N/I18N/BYOC #310

merged 11 commits into from
May 16, 2025

Conversation

jhaven-stytch
Copy link
Contributor

Ceremonial ticket to release BYOC work

jhaven-stytch and others added 10 commits May 6, 2025 10:14
#296)

* Rename all b2c strings, extract some that are shared, add helper for style annotations in string resources and verify it works in b2c UI

* Extract all b2b ui strings from views (still need to figure out error messages)

* All hardcoded strings are now resources

* Update tests

* Run all tests on ALL PRs/pushes, not just to main

* Maybe a little overzealous

* Lint
* Update error types from API workflow (#298)

Co-authored-by: Stytch Codegen Bot <support@stytch.com>

* Update error types from API workflow (#299)

Co-authored-by: Stytch Codegen Bot <support@stytch.com>

* Update error types from API workflow (#300)

Co-authored-by: Stytch Codegen Bot <support@stytch.com>

* Update error types from API workflow (#301)

Co-authored-by: Stytch Codegen Bot <support@stytch.com>

* Fix B2C UI memory leak (#303)

* Add Biometrics To The Consumer Prebuilt UI (#302)

* WIP: initial pass, get flows working

* Revisions per designs

* Extract string resources

* Standardize option name with iOS

* Lint and update tests

* Fix ui test

* Update all string keys

---------

Co-authored-by: ci-stytch <72180218+ci-stytch@users.noreply.github.com>
Co-authored-by: Stytch Codegen Bot <support@stytch.com>
* Add localization instructions/readme

* Link to Localization from main README

* Update localization readme
@jhaven-stytch jhaven-stytch requested a review from a team as a code owner May 16, 2025 15:06
@jhaven-stytch jhaven-stytch requested review from nidal-stytch and removed request for jbolduc-stytch May 16, 2025 15:07
@jhaven-stytch
Copy link
Contributor Author

Code Coverage

Overall Project 72.47% -0.09% 🍏
Files changed 0%

File Coverage
BiometricsProviderImpl.kt 3.37% -9.84%
StytchB2BAuthenticationApp.kt 0% 🍏

@jhaven-stytch jhaven-stytch merged commit 7117d0e into main May 16, 2025
4 checks passed
@jhaven-stytch jhaven-stytch deleted the feature/byoc branch May 16, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0