10000 WIP: Update Build to Vue CLI 3.0 by sagalbot · Pull Request #615 · sagalbot/vue-select · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

WIP: Update Build to Vue CLI 3.0 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 34 commits into from
Closed

WIP: Update Build to Vue CLI 3.0 #615

wants to merge 34 commits into from

Conversation

sagalbot
Copy link
Owner
@sagalbot sagalbot commented Aug 13, 2018 •
edited
Loading
  • updates previous webpack build system to use vue-cli-service build
  • updates dev environment, adds build command for netlify PR previews
  • adds linting
  • migrates test suite onto Jest / vue-test-utils

ToDo

Jeff added 20 commits August 7, 2018 23:00
vue cli scaffolding in place
c0ff414
Remove build and config folders
5c251f5
pull config to package.json
de73484
start converting unit tests
459fcb9
Complete 'selecting' test suite
d4954de
Further progress on test suite migration, all tests moved out of old …
143874a 
…files
Complete AJAX specs
3078fa6
Complete Layout specs
1554080
Complete pointer specs
294d169
Complete 'index' prop tests
3c2e8c1
- migrate tagging spec
eed25d7 
- add helpers
refactor ajax tests to use helpers
8e22400
Complete deselecting spec
4b5601b
Complete dropdown spec
0946165
Complete labels spec
c03b634
Fix console output in Jest runs
1c15fa0
Update yarn dev command and environment
046d4ce
Update gitignore, add build:dev command
b8696bc
disable linting on data files
80eefd4
Fix slot warning, update to slot-scope
48782a7
@sagalbot sagalbot self-assigned this Aug 13, 2018
@luishdz1010
Copy link

This refactoring seems to make possible including vue-select/src/index.js again for Nuxt2/Webpack 4, which was broken due to default exports using module.export. Thanks for the hard work!

@sagalbot
Copy link
Owner Author

@luisDanielRoviraContreras glad to hear it! Hoping to get this one merged in within the month.

@sagalbot sagalbot mentioned this pull request Sep 13, 2018
Closed
@luishdz1010
Copy link

Do you think this will land soon? Nuxt 2.0 just landed but vue-select won't work with the newer webpack 4.

This was referenced Jan 10, 2019
Closed
Merged
@yamsellem
Copy link

IMHO this PR is very ambitious: migrating from webpack to vue-cli 3, from karma to jest, from gitbook to vuepress.

@sagalbot may you consider splitting it? It has great value, but is somehow blocked due to is ambition.
I've just added a PR with only webpack 4 (related to SSR), maybe it's possible to release jest tests & lint first. Then merging webpack 4 or vue-cli 3 (testing the bundle with SSR and modules imports, in both cases I guess).

The vuepress may be handled later, I suppose.

It really seems to me that this migration is almost done, and it is maybe preventing some more to come. I'll be happy to here you on the matter.

Take care.

Jeff added 4 commits February 9, 2019 12:25
Merge remote-tracking branch 'origin/master' into ft/vue-cli-v3
d5dbda2 
# Conflicts:
#	README.md
#	dev/dev.html
#	package.json
#	test/unit/specs/Select.spec.js
- ignore dist
a05924f 
- remove lcov reporter
update vue cli
aabfaef
Merge branch 'master' into ft/vue-cli-v3
e8a12ee 
# Conflicts:
#	.gitignore
#	dev/dev.html
#	src/components/Select.vue
#	test/unit/specs/Select.spec.js
@sagalbot sagalbot closed this Apr 14, 2019
@sagalbot sagalbot deleted the ft/vue-cli-v3 branch December 28, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sagalbot sagalbot

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagalbot @luishdz1010 @yamsellem
0