8000 Fixed unresponsive vue-select after clicking custom no-options (#689, #648, #722, and #736) as well as isOptionSelected wrong check for object (#732) by MrStobbart · Pull Request #703 · sagalbot/vue-select · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed unresponsive vue-select after clicking custom no-options (#689, #648, #722, and #736) as well as isOptionSelected wrong check for object (#732) #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 9, 2019
Merged

Fixed unresponsive vue-select after clicking custom no-options (#689, #648, #722, and #736) as well as isOptionSelected wrong check for object (#732) #703

merged 8 commits into from
Feb 9, 2019

Conversation

MrStobbart
Copy link
Contributor

Fixes the the bugs #689 and #648 by making the vue-select still interactive after clicking a custom no-options message. To test this another vue-select was inserted into the test dev.html

This merge request is similar to #691 but prevents the bug when the users has typed something but the no-options message still appears.

MrStobbart added a commit to MrStobbart/vue-select that referenced this pull request Nov 15, 2018
@MrStobbart
Fixed naming of new dev.html vue select field (sagalbot#703)
12865d2
MrStobbart added a commit to MrStobbart/vue-select that referenced this pull request Nov 15, 2018
@MrStobbart
Removed useless if statement (sagalbot#703)
c3a469c
@MrStobbart MrStobbart mentioned this pull request Nov 15, 2018
Closed
@eriknygren
Copy link
Contributor

Nice one @MrStobbart. I had a trawl through the git log to see the original reason for that if statement: 350998b

Is this something that might have been reintroduced as a side effect?

@MrStobbart
Copy link
Contributor Author

@eriknygren Uh thanks for looking that up (should have thought about that myself).
I will do some tests tomorrow and check if that bug was reintroduced. If so I will try to find a solution for that. :)

MrStobbart added a commit to MrStobbart/vue-select that referenced this pull request Nov 17, 2018
@MrStobbart
Improved fix for unresponsive vue-select after clicking custom no-opt…
a3903cd 
…ions to not reintroduce old IE bug (sagalbot#703)
@MrStobbart
Copy link
Contributor Author

@eriknygren My first fix reintroduces the bug. I found a different solution, that is now also part of this pull request, that should close the issues #689 and #648 and does not reintroduce the IE bug that the commit 350998b fixed.

I tested the solution in Internet Explorer 11, Safari, Chrome, Firefox, Opera and Edge.
The behaviour when just clicking the vue-select without having typed something beforehand is still a bit odd, as the options can only be closed by selecting one of them. A solution for that would be to only have this behaviour for IE (so that scrolling is possible) and not for the other browsers. What do you think about that?

eriknygren
eriknygren reviewed Nov 19, 2018
View reviewed changes
Copy link
Contributor
@eriknygren eriknygren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the solution in Internet Explorer 11, Safari, Chrome, Firefox, Opera and Edge.
The behaviour when just clicking the vue-select without having typed something beforehand is still a bit odd, as the options can only be closed by selecting one of them. A solution for that would be to only have this behaviour for IE (so that scrolling is possible) and not for the other browsers. What do you think about that?

@MrStobbart nice work. Wether or not it would be okay to introduce slightly different behaviour in IE or not: I'm afraid that question is above my pay-grade 😎 I'd leave that up to @sagalbot

Anyway I had a look at the code and had a few questions/suggestions, let me know what you think

@MrStobbart
Copy link
Contributor Author

@eriknygren Ok, I would leave it as it is then and this slightly different behaviour could be done in a different pull request when necessary. Thanks for the feedback on the code and your quick responses!

@eriknygren
Copy link
Contributor
eriknygren commented Nov 20, 2018 •
edited
Loading

@eriknygren Ok, I would leave it as it is then and this slightly different behaviour could be done in a different pull request when necessary. Thanks for the feedback on the code and your quick responses!

@MrStobbart No worries, thank you!

@Tusko Tusko mentioned this pull request Dec 4, 2018
Closed
@MrStobbart MrStobbart changed the title Fixed unresponsive vue-select after clicking custom no-options Fixed unresponsive vue-select after clicking custom no-options (#689 and #648) as well as isOptionSelected wrong check for object (#732) Feb 8, 2019
@MrStobbart MrStobbart changed the title Fixed unresponsive vue-select after clicking custom no-options (#689 and #648) as well as isOptionSelected wrong check for object (#732) Fixed unresponsive vue-select after clicking custom no-options (#689, #648, #722, and #736) as well as isOptionSelected wrong check for object (#732) Feb 8, 2019
@MrStobbart
Copy link
Contributor Author

This pull request also fixes #722, and #736 and I added the suggested fix for #732.

@sagalbot sagalbot added this to the v2.6 milestone Feb 9, 2019
@sagalbot sagalbot self-assigned this Feb 9, 2019
@sagalbot sagalbot mentioned this pull request Feb 9, 2019
Closed
4 tasks
@sagalbot
Copy link
Owner
sagalbot commented Feb 9, 2019

Huge thanks to @MrStobbart and @eriknygren on this one! I'm not super concerned about different functionality in IE 11 at this point – the hack to fix behavior was causing so many issues for the much larger majority of users. I'm going to get this one in now and can address the IE issues as they come up.

Thanks again!

@sagalbot sagalbot merged commit 18416ba into sagalbot:master Feb 9, 2019
@sagalbot
Copy link
Owner
sagalbot commented Feb 9, 2019

Closes #689 #648 #722 #736 #732

This was referenced Feb 9, 2019
Closed
Closed
Closed
Closed
@sagalbot sagalbot modified the milestones: v2.6, v3.0 Feb 11, 2019
@victorsilent
Copy link

When it will be released? I have this bug with isOptionSelected

@sagalbot
Copy link
Owner
sagalbot commented Feb 14, 2019 •
edited
Loading

@victorsilent working on it this week. My plan was to just release 3.0, but if I revert a commit (8c622b6) I can push out 2.6 first.

@sergeyBreslavets
Copy link

try
<v-select v-if="drawComponent" .....
.......
<span slot="no-options" class="bag" @click="reset">
{{$t('text_start_search')}}

.......
reset: function() {
var vm = this;
console.log('wres')
vm.drawComponent = false;

    this.$nextTick(function() { .  // for nuxt     
      vm.drawComponent = true;
    });
    
 Vue.nextTick(function () { .   //vue      
vm.drawComponent = true;
  })     

  },
67E6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknygren eriknygren eriknygren left review comments

Assignees

@sagalbot sagalbot

Labels
in progress
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MrStobbart @eriknygren @sagalbot @victorsilent @sergeyBreslavets
0