-
Notifications
You must be signed in to change notification settings - Fork 43
feat(homepage): refine the content and add GSAP animation at homepage #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rockleona
wants to merge
64
commits into
sciwork:master
Choose a base branch
from
rockleona:feat/homepage_animation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developer can use Map compoment directly in mdx without import
Signed-off-by: chestercheng <hi@chester.ch>
Note: icons is IconDefinition type, so it cannot pass into components in MDXRemote. Therefore I add TagIcon component to prevent this issue.
Signed-off-by: chestercheng <hi@chester.ch>
@rockleona Does GSAP animation works well on mobile device? |
Yes, I've also simulated on mobile device as well, it can work smoothly. |
build(pnpm): changing package manager to pnpm
* refactor: remove unnecessary function call * refactor: remove importing customzied css class in blog markdown files * feat: add author and date * style(.prettierignore): ignore .mdx * feat: add AgendaTable * feat: replace with AgendaTable component
a3c87c5
to
659b901
Compare
Looks like the animation too small on mobile, I'll make a commit to fix this tomorrow. |
3397ccc
to
fa7e72f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first try of refine homepage, I've added the animation at the landing page, you may check at the preview.
Also here are some changes that may affect to others or developments afterward:
Container
, it will have padding and not fullscreen width if I want to develop animation at homepage, so I created nested layout under every paths; Therefore, the root layout, which homepage would only render this, removedContainer
for a better animation display.homepage
folder under/components/
to create each parts of animation at homepage, wondering if this is a good behavior or not? I would like to learn comment from @jack482653.