Make sure that light and dark mode colors are being used throughout the app #360
Comments
|
CC @DeleMike, would you want to look into this? :) First thing would be to figure out which colors aren't reactive. |
|
Yeah, I will look into this. Thanks! |
|
Hello @andrewtavis , I'm so sorry this took a bit of time. I was really engaged with other things.
For this task, I have pulled the latest source code, and I do not see the issue. I think the bottom nav bar issue I fixed earlier resolves the only issue related to this issue. Have you run through the app to check if there are any specific screens that have this issue? I have gone through it and I can't find. Thanks. |
|
No stress, @DeleMike! Just checking, this is specifically checking that we have no instances where the same color is being used in light and dark mode. All colors in the app should have light and dark mode variants. Is this the case? |
|
Might make sense to look into #358 in the meantime once we finalize the assessment here :) |
Yes, for now I have checked everything and all seems good. But you can check too. I will definitely check out #358 |
|
I'll look into this and likely close it then. Thanks for the heads up, @DeleMike! |
|
Hey @DeleMike, There is an instance where the app shows a change in the color of the keyboard when in light and dark mode. When the overall mode is light and the app mode is in dark. The scribe keys are not in the right color in the keyboard. This could be one of the things to be checked out. |
|
Thanks for pointing this out, @angrezichatterbox! Do you know of any instances where we're using hard coded colors instead of light/dark mode variant colors? |
|
In the above case the colors are coded right. It syncs according to the dark and light mode of the system rather than the app. There are other situation in the keyboard where this has happened. For the application it has been consistent throughout following the app dark and light mode setting. |
Do you mean that when the phone is in light mode and the app is in the dark mode the keyboard keys are still in light mode? [EDIT] : |
|
I just checked the keyboard UI. The keyboard will show dark when my test device theme mode is light and the app theme is dark. Are you suggesting that we ensure that the device's theme takes precedence? @angrezichatterbox ? |
|
For me it would make sense that the app color mode takes preference over the system color mode at all times. Let us know if you have a different opinion here, @angrezichatterbox :) |
|
From a discussion in the Outreachy sync, we're all in agreement that we want the keyboard color mode to reflect the color mode from the application :) This is already the case. The one thing that's needed to close this issue is that the Scribe Blue color for the keyboard is being determined by the system color mode. So if we switch the app to dark mode, then the keyboard is correctly in dark mode, but the Scribe key color is still light mode until we have switched the system color mode to dark mode :) |
Terms
Description
In some instances the colors that are being used in the app are the same for both light and dark mode. We should check to make sure that we're using colors that are reactive to light and dark mode, with one instance being the grey for the tab bar icons when the options aren't selected. The colors that should be used in the app can be found in the Figma designs.
Contribution
Happy to support with this as I can and review a PR! 🎨
The text was updated successfully, but these errors were encountered: