fix: scribe button theme color #419
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
Hi @andrewtavis @angrezichatterbox this is the fix for #360 , what do you think? |
|
Thanks for the great efforts here, @DeleMike! One thing I'm seeing is that we need to consider this for the other Scribe blue keys on the keyboard. This is what we have for dark mode for the device and light mode for the keyboard, where we can see that the command button colors aren't correct either. Specifically we also need to make sure that the enter button when the keyboard is in command mode is also the correct color - so when we press the Scribe key and then select a command, the enter key changes color to Scribe blue and has a play icon on it. This blue should match the Scribe key. Note that I haven't tested this explicitly, but we should check to make sure that it works 😊 |
|
Thanks @andrewtavis , I understand some things. A few questions:
this is what we want now, right? the scribe action buttons The enter key color This is the Figma design for the keyboard when in light mode. |
|
Hey @DeleMike 👋 Answers to your questions 😊
Yes, the Scribe Key, all command keys (translate, conjugate and plural) and enter while in command mode should all be the same color blue for light and dark mode, and this color should be first controlled by the app color and second controlled by the system color.
Exactly :) I'll type out some vocabulary: The Top left button is the Scribe key, and pressing that enters command mode where the buttons for the commands are shown. When pressing any command button we see the command bar and the enter key changes color to indicate that the command can be executed.
Exactly. This color change is already being done, but we need to make sure that the color of Scribe blue is consistent with the Scribe key and command keys. Note that we don't want the enter key to always be Scribe blue. We only want this change to happen when a command has been selected in command mode :)
Thank you so much! 😊 |
|
Thanks! looking into it! |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This PR is to fix scribe action button theme color to priortise app's theme mode over system mode.
Video demo below
Screenrecorder-2025-05-31-15-24-51-84.mp4
see screenshot to verify
Scribe btn theme when keyboard is in dark mode
Scribe btn theme when keyboard is in light mode
Also, please describe shortly how you tested that your change actually works.
Related issue