8000 change unselected color and remove tab bar animation by DeleMike · Pull Request #353 · scribe-org/Scribe-Android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

change unselected color and remove tab bar animation #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

change unselected color and remove tab bar animation #353

merged 2 commits into from
Apr 11, 2025

Conversation

DeleMike
Copy link
Collaborator
@DeleMike DeleMike commented Apr 5, 2025 •
edited
Loading

Contributor checklist

Description

Related issue

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 5, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions GitHub Actions
Copy link
github-actions bot commented Apr 5, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@DeleMike
Copy link
Collaborator Author
DeleMike commented Apr 5, 2025 •
edited
Loading
Screenrecorder-2025-04-05-10-17-04-49.mp4

@andrewtavis , what do you think of this? Do you think this shade of grey is good enough?
I will also fix the linting

@andrewtavis
Copy link
Member

I think it's looking great, @DeleMike! Let's fix the linting errors and then we can work to bring this in 🚀

@DeleMike DeleMike marked this pull request as ready for review April 6, 2025 14:19
@DeleMike
Copy link
Collaborator Author
DeleMike commented Apr 6, 2025

Hii @andrewtavis, The PR is ready for review. What do you think about the bottom bar?

@andrewtavis
Copy link
Member

Will finalize this tonight or tomorrow, @DeleMike! Thanks for the help here! 😊

andrewtavis
andrewtavis approved these changes Apr 11, 2025
View reviewed changes
Copy link
Member
@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's looking great here, @DeleMike! Let's maybe look into whether light and dark mode colors are being used throughout the app :) I'll make an issue for this and maybe you could check it out?

Sorry for the wait! 😊

@andrewtavis andrewtavis merged commit cf0a573 into scribe-org:main Apr 11, 2025
5 checks passed
@DeleMike DeleMike mentioned this pull request May 2, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtavis andrewtavis andrewtavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve styling of tab bar buttons
2 participants
@DeleMike @andrewtavis
0