8000 Refactor git commit verification into its own interface. by wlynch · Pull Request #167 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor git commit verification into its own interface. #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2022
Merged

Refactor git commit verification into its own interface. #167

merged 1 commit into from
Oct 20, 2022

Conversation

wlynch
Copy link
Member
@wlynch wlynch commented Oct 19, 2022

Summary

This pulls out git commit verification logic (e.g. everything but Rekor lookups) into it's own interface + struct so that it can be more easily configured with user settings.

Bumps s/s dependency to pull in sigstore/sigstore@4f1461d

The only new change in behavior is the inclusion of the system cert pool in the default cert pool used for validation.

This is setup for #166 to allow for more flexibility in client creation. (main...wlynch:certpool if you want to see what this will look like)

Release Note

BREAKING CHANGE: git.Verify now requires a new git.Verifier param.

Documentation

NONE

@wlynch wlynch requested a review from imjasonh October 19, 2022 14:52
@wlynch wlynch force-pushed the git-verifier branch 2 times, most recently from a5cf872 to 4aa7633 Compare October 19, 2022 14:54
cpanato
cpanato previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member
@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cool

@wlynch
Refactor git commit verification into its own interface.
b51b573 
This pulls out git commit verification logic (e.g. everything but Rekor
lookups) into it's own interface + struct so that it can be more easily
configured with user settings.

The only new change in behavior is the inclusion of the system cert pool
in the default cert pool used for validation.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
@wlynch wlynch requested a review from cpanato October 20, 2022 01:07
@wlynch wlynch mentioned this pull request Oct 20, 2022
Merged
@wlynch wlynch merged commit 6a3b4aa into sigstore:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wlynch @cpanato
0