8000 Add fulcio root config option. by wlynch · Pull Request #170 · sigstore/gitsign · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add fulcio root config option. #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2022
Merged

Add fulcio root config option. #170

merged 2 commits into from
Oct 20, 2022

Conversation

wlynch
Copy link
Member
@wlynch wlynch commented Oct 20, 2022

Summary

Allows callers to specify a Fulcio root to use when verifying
signatures. Useful for configuring gitsign to use non-TUF instances of
Sigstore.

Creates new fulcioroot package to allow configuration of what certs get
loaded in.

Dependent on #167
Fixes #169

Release Note

Adds GITSIGN_FULCIO_ROOT config option.

Documentation

README updated, will update docs for next release.

@wlynch
Add fulcio root config option.
7b01df0 
Allows callers to specify a Fulcio root to use when verifying
signatures. Useful for configuring gitsign to use non-TUF instances of
Sigstore.

Creates new fulcioroot package to allow configuration of what certs get
loaded in.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
znewman01
znewman01 previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
@znewman01 znewman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry you have to make your own fulcioroots.go :'(

Hopefully that will change long-term.

@wlynch
Update README to mention SIGSTORE_ROOT_FILE support, link to cosign docs
123d604 
for setting up other instances.

Signed-off-by: Billy Lynch <billy@chainguard.dev>
@wlynch
Copy link
Member Author
wlynch commented Oct 20, 2022

So sorry you have to make your own fulcioroots.go :'(

Hopefully that will change long-term.

I intentionally wrote it fairly generic so it should be easy to steal for sigstore-go when we're ready 😎

@wlynch wlynch requested a review from znewman01 October 20, 2022 16:17
@wlynch wlynch merged commit d5e5f04 into sigstore:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znewman01 znewman01 znewman01 approved these changes

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitsign doesn't respect SIGSTORE_ROOT_FILE
3 participants
@wlynch @znewman01 @priyawadhwa
0