8000 [MNT] make `pyproject.toml` parsing for differential testing more robust against non-package relevant changes by fkiraly · Pull Request #6882 · sktime/sktime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MNT] make pyproject.toml parsing for differential testing more robust against non-package relevant changes #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2024
Merged

[MNT] make pyproject.toml parsing for differential testing more robust against non-package relevant changes #6882

merged 2 commits into from
Aug 5, 2024

Conversation

fkiraly
Copy link
Collaborator
@fkiraly fkiraly commented Aug 4, 2024

This PR makes pyproject.toml parsing for differential testing more robust against non-package relevant changes, e.g., if a line is added that is not a valid package requirement string, such as in a case where pyproject.toml is changed outside the dependency specifications block.

Currently, this leads to an exception in _get_packages_with_changed_specs.

With the change, no exception is raised, as it is caught and considered a non-package related line.

8000
@fkiraly fkiraly added maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests enhancement Adding new functionality labels Aug 4, 2024
@fkiraly fkiraly mentioned this pull request Aug 4, 2024
Merged
6 tasks
yarnabrina
yarnabrina approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member
@yarnabrina yarnabrina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming #6876 can be considered as a indirect diagnostic PR.

@fkiraly
Copy link
Collaborator Author
fkiraly commented Aug 5, 2024

I suppose so.

@fkiraly fkiraly merged commit fbdd4f0 into main Aug 5, 2024
36 of 44 checks passed
@fkiraly fkiraly deleted the robust-pkg_diff branch August 5, 2024 10:21
fkiraly pushed a commit that referenced this pull request Aug 7, 2024
@mateuszkasprowicz
[ENH] Link to docs in object's html repr (#6876)
c1f03c5 
#### Reference Issues/PRs
Implements #6812

Depends on #6882 for the css fix

#### What does this implement/fix? Explain your changes.

- Adds a (?) icon with a link to docs to object's html representation
- Updates the html repr CSS style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarnabrina yarnabrina yarnabrina approved these changes

@achieveordie achieveordie Awaiting requested review from achieveordie

@benHeid benHeid Awaiting requested review from benHeid benHeid is a code owner

Assignees
No one a 5099 ssigned
Labels
enhancement Adding new functionality maintenance Continuous integration, unit testing & package distribution module:tests test framework functionality - only framework, excl specific tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fkiraly @yarnabrina
0