8000 [MNT] make `pyproject.toml` parsing for differential testing more robust against non-package relevant changes by fkiraly · Pull Request #6882 · sktime/sktime · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[MNT] make pyproject.toml parsing for differential testing more robust against non-package relevant changes #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024
Merged

[MNT] make pyproject.toml parsing for differential testing more robust against non-package relevant changes #6882

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6e3cf6
Update git_diff.py
fkiraly Aug 4, 2024
6b39fb3
comment
fkiraly Aug 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sktime/utils/git_diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def _get_packages_with_changed_specs():
-------
tuple of str : names of packages with changed or added specs
"""
from packaging.requirements import Requirement
from packaging.requirements import InvalidRequirement, Requirement

changed_lines = get_changed_lines("pyproject.toml")

Expand All @@ -175,8 +175,12 @@ def _get_packages_with_changed_specs():
if ";" in req:
req = req.split(";")[0]

pkg = Requirement(req).name
packages.append(pkg)
try: # deal with lines that are not package requirement strings
pkg = Requirement(req).name
except InvalidRequirement:
continue
else:
packages.append(pkg)

# make unique
packages = tuple(set(packages))
Expand Down
Loading
0