Fix aws_db_instance false-positives #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.9 #545 +/- ##
==========================================
- Coverage 70.89% 70.85% -0.05%
==========================================
Files 289 289
Lines 6549 6553 +4
==========================================
Hits 4643 4643
- Misses 1526 1529 +3
- Partials 380 381 +1
|
509e846 to
6bddc5e
Compare
wbeuil
suggested changes
May 25, 2021
wbeuil
reviewed
May 25, 2021
9ea5f40 to
1acee71
Compare
8000
wbeuil
suggested changes
May 25, 2021
wbeuil
approved these changes
May 25, 2021
This was referenced May 26, 2021
Closed
eliecharra
reviewed
May 31, 2021
| @@ -14,9 +14,15 @@ func (r *AwsDbInstance) NormalizeForState() (resource.Resource, error) { | |||
| if r.ApplyImmediately != nil && !*r.ApplyImmediately { | |||
| r.ApplyImmediately = nil | |||
| } | |||
| if r.CharacterSetName != nil && *r.CharacterSetName == "" { | |||
There was a problem hiding this comment.
Good catch will do it now !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix false positive for aws_db_instance CharacterSetName
Add Acc test.
Maybe it's need to change pkg/iac/terraform/state/test/db_instance/terraform.tfstate and pkg/iac/terraform/state/test/db_instance/result.golden.json, let me know.