8000 Backport v0.9 into main branch by sundowndev · Pull Request #556 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Backport v0.9 into main branch #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 27, 2021
Merged

Backport v0.9 into main branch #556

merged 8 commits into from
May 27, 2021

Conversation

sundowndev
Copy link
Contributor

Changelog

🚀 Features

🐛 Bug Fixes

@sundowndev sundowndev mentioned this pull request May 26, 2021
Closed
@codecov
Copy link
codecov bot commented May 26, 2021 •
edited
Loading

Codecov Report

Merging #556 (7d31825) into main (b644d7f) will increase coverage by 0.15%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   70.31%   70.47%   +0.15%     
==========================================
  Files         293      294       +1     
  Lines        7102     7157      +55     
==========================================
+ Hits         4994     5044      +50     
- Misses       1758     1763       +5     
  Partials      350      350
Impacted Files Coverage Δ
pkg/cmd/scan.go 81.77% <0.00%> (-0.35%) ⬇️
pkg/resource/aws/aws_db_instance_ext.go 0.00% <0.00%> (ø)
pkg/analyser/analysis.go 97.95% <100.00%> (+0.55%) ⬆️
pkg/cmd/driftctl.go 80.39% <100.00%> (+0.39%) ⬆️
pkg/cmd/gen_driftignore.go 100.00% <100.00%> (ø)

@sundowndev sundowndev marked this pull request as ready for review May 26, 2021 09:27
@sundowndev sundowndev requested a review from a team as a code owner May 26, 2021 09:27
wbeuil
wbeuil approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor
@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge it now please, will do it later.

@wbeuil wbeuil merged commit 0a9cb8a into main May 27, 2021
@wbeuil wbeuil deleted the v0.9-rebase branch May 27, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundowndev @wbeuil @lotoussa
0