8000 Split iam user by lotoussa Β· Pull Request #827 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Split iam user #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

Split iam user #827

merged 2 commits into from
Jul 9, 2021

Conversation

lotoussa
Copy link
Contributor
@lotoussa lotoussa commented Jul 9, 2021
Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #729
❓ Documentation no

@lotoussa lotoussa added the kind/maintenance Refactoring or changes to the workspace label Jul 9, 2021
@lotoussa lotoussa added this to the Deep Mode milestone Jul 9, 2021
@lotoussa lotoussa requested a review from a team as a code owner July 9, 2021 11:04
@lotoussa lotoussa 8000 self-assigned this Jul 9, 2021
@codecov
Copy link
codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #827 (cbac4f6) into main (24baf95) will increase coverage by 0.10%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #827      +/-   ##
==========================================
+ Coverage   78.95%   79.06%   +0.10%     
==========================================
  Files         226      226              
  Lines        6377     6367      -10     
==========================================
- Hits         5035     5034       -1     
+ Misses       1118     1111       -7     
+ Partials      224      222       -2
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/iam_user_enumerator.go 100.00% <100.00%> (ΓΈ)

@lotoussa lotoussa force-pushed the issue_729_split_iam_user branch from 235f832 to 41547e3 Compare July 9, 2021 11:11
@lotoussa lotoussa mentioned this pull request Jul 9, 2021
Merged
@wbeuil wbeuil linked an issue Jul 9, 2021 that may be closed by this pull request
Split iam_user_supplier #729
Closed
@lotoussa lotoussa force-pushed the issue_729_split_iam_user branch from 41547e3 to 5021803 Compare July 9, 2021 14:17
@lotoussa lotoussa merged commit 9ea966a into main Jul 9, 2021
@lotoussa lotoussa deleted the issue_729_split_iam_user branch July 9, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbeuil wbeuil wbeuil approved these changes

@sundowndev sundowndev sundowndev approved these changes

Assignees

@lotoussa lotoussa

Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
Deep Mode
Development

Successfully merging this pull request may close these issues.

Split iam_user_supplier
3 participants
@lotoussa @wbeuil @sundowndev
0