8000 Split iam_user_policy_supplier by lotoussa Β· Pull Request #828 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Split iam_user_policy_supplier #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

Split iam_user_policy_supplier #828

merged 1 commit into from
Jul 12, 2021

Conversation

lotoussa
Copy link
Contributor
@lotoussa lotoussa commented Jul 9, 2021
Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #728
❓ Documentation no

Description

Merge after #729 #827
And check this one correctly, i'm not sure about it.

@lotoussa lotoussa added the kind/maintenance Refactoring or changes to the workspace label Jul 9, 2021
@lotoussa lotoussa added this to the Deep Mode milestone Jul 9, 2021
@lotoussa lotoussa self-assigned this Jul 9, 2021
@lotoussa lotoussa requested a review from a team as a code owner July 9, 2021 11:42
@codecov
Copy link
codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #828 (65a4e82) into main (9ea966a) will increase coverage by 0.10%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   79.06%   79.17%   +0.10%     
==========================================
  Files         226      226              
  Lines        6367     6357      -10     
==========================================
- Hits         5034     5033       -1     
+ Misses       1111     1104       -7     
+ Partials      222      220       -2
Impacted Files Coverage Ξ”
pkg/remote/aws/init.go 0.00% <0.00%> (ΓΈ)
pkg/remote/aws/iam_user_policy_enumerator.go 100.00% <100.00%> (ΓΈ)

@wbeuil wbeuil marked this pull request as draft July 9, 2021 12:50
@wbeuil wbeuil linked an issue Jul 9, 2021 that may be closed by this pull request
Split iam_user_policy_supplier #728
Closed
@lotoussa lotoussa force-pushed the issue_728_split_iam_user_policy branch from aaa6c4c to bbd2e4b Compare July 9, 2021 14:18
@lotoussa lotoussa force-pushed the issue_728_split_iam_user_policy branch from bbd2e4b to 65a4e82 Compare July 9, 2021 15:21
@lotoussa lotoussa marked this pull request as ready for review July 9, 2021 15:22
@sundowndev sundowndev changed the title split iam user policy | MERGE AFTER #729 split iam user | Split iam_user_policy_supplier Jul 12, 2021
@sundowndev sundowndev merged commit 57a0c38 into main Jul 12, 2021
@sundowndev sundowndev deleted the issue_728_split_iam_user_policy branch July 12, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadibfr moadibfr moadibfr approved these changes

@sundowndev sundowndev sundowndev approved these changes

Assignees

@lotoussa lotoussa

Labels
kind/maintenance Refactoring or changes to the workspace
Projects
None yet
Milestone
Deep Mode
Development

Successfully merging this pull request may close these issues.

Split iam_user_policy_supplier
3 participants
@lotoussa @moadibfr @sundowndev
0