8000 feat: add iac source to drift in console output by functionstackx Β· Pull Request #934 Β· snyk/driftctl Β· GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add iac source to drift in console output #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 26, 2021
Merged

feat: add iac source to drift in console output #934

merged 7 commits into from
Aug 26, 2021

Conversation

functionstackx
Copy link
Contributor
@functionstackx functionstackx commented Aug 23, 2021 •
edited
Loading
Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #909
❓ Documentation no

Description

image

@functionstackx functionstackx requested a review from a team as a code owner August 23, 2021 21:41
@functionstackx functionstackx changed the title feat: add iac source to drift in console output WIP: feat: add iac source to drift in console output Aug 23, 2021
@codecov
Copy link
codecov bot commented Aug 24, 2021 •
edited
Loading

Codecov Report

Merging #934 (e39e43b) into main (95e665f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #934      +/-   ##
==========================================
+ Coverage   82.28%   82.29%   +0.01%     
==========================================
  Files         222      222              
  Lines        7348     7354       +6     
==========================================
+ Hits         6046     6052       +6     
  Misses       1112     1112              
  Partials      190      190
Impacted Files Coverage Ξ”
pkg/cmd/scan/output/console.go 97.46% <100.00%> (+0.09%) ⬆️

@functionstackx functionstackx changed the title WIP: feat: add iac source to drift in console output feat: add iac source to drift in console output Aug 24, 2021
sundowndev
sundowndev previously requested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor
@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work πŸ‘πŸΌ

Just left a comment about the output itself

eliecharra
eliecharra suggested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor
@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution @OrenLeung πŸŽ‰ I only got a small typo remark in addition of @sundowndev comment πŸ‘πŸ»

@sundowndev sundowndev added the kind/enhancement New feature or improvement label Aug 24, 2021
@eliecharra eliecharra merged commit ed4d560 into snyk:main Aug 26, 2021
@eliecharra
Copy link
Contributor
8000

@all-contributors please add @OrenLeung for code

@allcontributors allcontributors bot mentioned this pull request Aug 26, 2021
Merged
@allcontributors
Copy link
Contributor

@eliecharra

I've put up a pull request to add @OrenLeung! πŸŽ‰

@functionstackx functionstackx mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliecharra eliecharra eliecharra approved these changes

@sundowndev sundowndev Awaiting requested review from sundowndev

Assignees
No one assigned
Labels
kind/enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@functionstackx @eliecharra @sundowndev
0