8000 Revert "feat: add iac source to drift in console output" by functionstackx · Pull Request #962 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Revert "feat: add iac source to drift in console output" #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "feat: add iac source to drift in console output" #962

wants to merge 1 commit into from

Conversation

functionstackx
Copy link
Contributor
@functionstackx functionstackx commented Aug 27, 2021 •
edited
Loading

Reverts #934

Bug

deletedResource.Source == nil if it is deleted.

Steps to reproduce:

  • create ec2 through terraform
  • delete ec2 through the console
  • run it and deletedResource.Source is nil

Steps to Resolve

  • resource.Source needs to be declared even when it is a deleted resource

relates to #901

@functionstackx functionstackx requested a review from a team as a code owner August 27, 2021 18:10
@eliecharra
Copy link
Contributor

@OrenLeung I'm not sure to get it, a deleted resource mean that it exist in terraform but not in your cloud provider. I mean even if the resource is deleted on the cloud provider, we are still able to determine the source since we determine the source based on IaC (terraform state).

The only kind of resource that should not have a source are unmanaged ones.

Are you sure that you are not in the case covered here : #942 ?
We identified some case where the source can be null and the issue #942 is here to debate how can we solve this.

@functionstackx
Copy link
Contributor Author

@eliecharra i am not sure if it is covered by #942 let me debug a bit further. It might because of a "virtual" EBS

@eliecharra eliecharra marked this pull request as draft September 16, 2021 08:42
@eliecharra
Copy link
Contributor

I'm closing this, please reopen if needed

@eliecharra eliecharra closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@functionstackx @eliecharra
0