Run provider gRPC configure anyway #1139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliecharra
approved these changes
Oct 18, 2021
Codecov Report
@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
- Coverage 81.49% 81.48% -0.02%
==========================================
Files 323 323
Lines 11820 11822 +2
==========================================
Hits 9633 9633
- Misses 1945 1947 +2
Partials 242 242
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Azure provider doesn't have a provider config specified, which is fine. But the actual behavior is to not run configure grpc function when no config is specified which make resource reading failing. This PR fixes that by running the configure function anyway with a nullable provider config.