10000 Fix azure provider configuration by eliecharra · Pull Request #1159 · snyk/driftctl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix azure provider configuration #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix azure provider configuration #1159

merged 1 commit into from
Oct 22, 2021

Conversation

eliecharra
Copy link
Contributor
Q A
🐛 Bug fix? yes
🚀 New feature? no
⚠ Deprecations? no
❌ BC Break no
🔗 Related issues none
❓ Documentation no

Description

Since we now configure the provider (#1139), it seems that it try to fallback to azure CLI, and when CLI is not installed it fail.
I have choosen to configure explicitly the provider.

@eliecharra eliecharra requested a review from a team as a code owner October 22, 2021 09:07
@eliecharra eliecharra added kind/bug Something isn't working priority/0 labels Oct 22, 2021
@codecov
Copy link
codecov bot commented Oct 22, 2021

Codecov Report

Merging #1159 (cc173e0) into main (7dbbb04) will increase coverage by 10.68%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1159       +/-   ##
===========================================
+ Coverage   70.63%   81.31%   +10.68%     
===========================================
  Files         394      339       -55     
  Lines       14533    12336     -2197     
===========================================
- Hits        10265    10031      -234     
+ Misses       3998     2050     -1948     
+ Partials      270      255       -15
Impacted Files Coverage Δ
pkg/remote/azurerm/provider.go 43.18% <0.00%> (-17.43%) ⬇️
pkg/terraform/plugin_client.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/remote/github/init.go 0.00% <0.00%> (-76.32%) ⬇️
pkg/terraform/provider_factory.go 0.00% <0.00%> (-62.50%) ⬇️
pkg/terraform/providers.go 52.94% <0.00%> (-47.06%) ⬇️
pkg/output/printer.go 55.55% <0.00%> (-44.45%) ⬇️
pkg/remote/terraform/provider.go 6.08% <0.00%> (-37.17%) ⬇️
pkg/remote/remote.go 40.00% <0.00%> (-20.00%) ⬇️
pkg/cmd/scan.go 74.56% <0.00%> (-15.56%) ⬇️
pkg/cmd/scan/output/output.go 72.00% <0.00%> (-12.00%) ⬇️
... and 61 more

@eliecharra eliecharra merged commit 86b5e27 into main Oct 22, 2021
@eliecharra eliecharra deleted the fix_azure branch October 22, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundowndev sundowndev sundowndev approved these changes

Assignees
No one assigned
Labels
kind/bug 4948 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliecharra @sundowndev
0